vsamarth / pe Goto Github PK

The edit command removes all previous tag values (and is not specified in the UG).
If a person has a long list of tags, this command may lose the data the user previously had and there is no way to add an additional tag.

edit 2 t/dentist loses previous colleagues and friends tag.

The DG does not have user stories for some features added such as undo/redo and autocompletion which makes it hard to understand the motivation behind the features

In the details for the Undo/Redo feature, the DG discusses how the current state is handled when redo or undo command is executed.

However, it is possible for the state tree to be non linear. For example, lets say there are three linear states a -> b -> c. undoing from c and then making a change creates another branch a->b>d.

The user guide does not explain what happens to the state tree in such a case and what option would be chosen if someone called redo from b.

The expected behaviour in such a case would be to go to state d but then state c would be lost (which should be mentioned, at least).

Setting the name as " Alex" instead of "Alex" fails to load the app with the data.
This input is correct according to the specifications of the UG but fails to load data.

There are user stories about being able to sort the data but which is not implemented in the application.

A user can add an invalid email address such as hello@hello without any domain name.

the help command is missing in the command summary section of the user guide.

Consider the case where the app data file contained invalid values and could not load the contacts into the app.

Then the user fixes the problem in the data file and runs list. I would expect the list command to give the list of contacts from the file.

However, it just writes an empty contacts list into the json file which loses all the data. Either the list command should be made undoable or it should be mentioned that list command also changes the file.

Even though familiar users might understand what AddressBook refers to, it might be confusing to introduce unknown terminology without defining it previously.

Also since the application is not address book, it should be renamed to something else

If we try to delete multiple contacts in one go with two valid indexes and one invalid, it just says invalid index provided and it's not helpful as to what index was invalid or if any contacts have been deleted or not.

Manually editing the tagged value to an incorrect format (adding spaces) makes the application stop working (all data is lost).

Even if one contact is invalid, not all data should be lost and some error message should be indicated to show that there is some problem

Note: It might also be considered a High level bug because the user guide suggests that the user can change the details in the json file and thus should have more robust error checking to deal with incorrect input.

Still uses addressbook (AB3) Reference

The configuration guide linked in the DG just says some aspects of the app can be modified without giving any details what can be edited, leaving the user to wonder and figure it out themselves.