Comments (5)
To put this issue into context;
- Enabling the plugin through puppet wasn't possible with the module before #909 were fixed (so, this is OK)
- Changing any of the default behavior is as far as I can tell not possible (unless through some secret undocumented way) with the classic configuration format.
from puppet-rabbitmq.
Is it working now that #909 is resolved, or is any additional fix needed?
from puppet-rabbitmq.
Enabling the plugin works (rabbitmq_plugin {'prometheus': ensure => present; }
-> fine)
(I want to add that there's a none-zero chance that I've somehow overlooked something with the below claims, but I haven't found a way around this)
Configuring the plugin is another matter. Let's say I want to change the TCP-port the prometheus endpoint listen on. Using the sysctl-format config file, I would do: prometheus.tcp.port = 31337
-- but I can't find a way to change the defaults of this plugin with the classic (and long deprecated) format.
This issue may be a duplicate of #829 at this point -- but it should be mentioned that upstream documentation is either incomplete when it comes to the classic format, or some features there are missing altogether.
from puppet-rabbitmq.
Dropping support for, say, <= 3.7 (which has now been around since ~ 2017) would probably simplify a number of things (for example, the availability of json formatted output, version being available without rabbitmq already being started / running), etc.
This could go along with breaking changes as proposed in #845 etc.
I have very little time / energy (or incentive) to do anything that big or structural with this module, but will be happy to advise or help in some small ways if someone wants to start taking this on. The new config file format seems more readable, and in some ways would presumably be easier to manage via Puppet as well.
It would probably take some work, in particular, reworking both unit and integration tests, and it will be most easy for someone who can get the integration tests working well locally. In short, it's going to take someone with some fairly good experience with Puppet and its internals (including types / providers), as well as recent experience using Rabbitmq, and some time to spare, to really make the kind of improvements in this module that needs to be made.
I would have assumed that it would be possible to configure it with the old config format, but it also seems non-obvious how to line up the old / new style directives (and maybe it's just not possible?)
from puppet-rabbitmq.
Ran into this same issue as @kvisle, not sure if the problem still exists, but what i did was use the newer 'sysctl' config format (rabbitmq.conf) and fill it with .erb file that contains the stuff i want to change. Configured rabbitmq-env.conf to have ADVANCED_CONFIG_FILE and CONFIG_FILE to point to their respective files. This way the original config can stay put and i can configure Prometheus.tcp.port via Puppet.
Still need to figure out how i can configure rabbitmq class to not touch rabbitmq.config as that's being set when you use the rabbitmq
class. I can change the used .erb template but that won't help me afaik.
from puppet-rabbitmq.
Related Issues (20)
- need support for newer versions of dependency puppet-archive HOT 1
- rabbitmq_plugin not working properly with RabbitMQ 3.10.x
- Unable to use custom list inside enabled_plugins file HOT 1
- Missing option to add members to quorum queue
- Idempotency issue with implicitly enabled plugins
- PackageCloud repos are no longer available (see RabbitMQ issue) HOT 2
- Method to enable HSTS? HOT 1
- rabbitmq_queue takes a long time when a large number of vhosts is present
- rabbitmq::install::rabbitmqadmin keeps installing python package HOT 2
- Question: Will support be added for Puppet 8 and RHEL8? HOT 5
- Policy "applyto" options missing HOT 2
- ldap_log should be string not boolean to support network/network_unsafe options HOT 3
- resources fail to prefetch when rabbitmq is not intended to be installed (via --noop or --tags) HOT 5
- Missing support for Vhost Metadata HOT 5
- puppet-archive version HOT 2
- Use epp template to handle sensitive data
- Add support for policy definition consumer-timeout as a integer HOT 1
- Failing with "Language validation logged 2 errors" HOT 2
- Module fails on puppet 7.29.0 + puppetserver 7.16.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-rabbitmq.