Missing support for Vhost Metadata about puppet-rabbitmq HOT 5 CLOSED

That works for me. Is there anyone specific you suggest I should ask for feedback

The #voxpupuli on the Puppet Slack or Vox's IRC channel would probably be good places to get opinions (or help), or you could see if @ekohl wants to weigh in.

I would also definitely suggest getting the integration tests working locally in Docker if at all possible - it'll really help testing / iteration, as well as making sure that your acceptance tests more or less work before you push up. You can spin up the test with BEAKER_destroy=no and exec in after it's done and then use that to try different stuff.

Or do a version check to decide which to use as default?

I think Vox typically tries to keep behavior consistent within the module within reason (vs. tying default behavior to the RMQ version). There's still a quite of bit of work to do anyway if this module is ever going to properly ship with RMQ 4.x by default (or, probably, even support it), so, with the caveat that I haven't used RMQ or Puppet for quite some number of years, I would say use classic as the default, and if / when the default behavior changes, ideally, update the default along with that (or update as another breaking change). But it's not a strong preference from my end.

from puppet-rabbitmq.

@wyardley I thought I might take a stab at this. How do you feel about this syntax?

rabbitmq_vhost { 'myvhost':
  ensure   => present,
  metadata => {
    'description'        => 'myvhost description',
    'default_queue_type' => 'quorum',
    'tags'               => 'myvhost tags',
  }
}

from puppet-rabbitmq.

Maybe get some other feedback too, but my high level thought is that maybe some or all of these should be first class params vs in a metadata hash? in particular, with tags, there seems to be a pattern of having a tags list for some resource types which I think are roughly analagous, e.g.,

Could some of these be actual (optional, if needed), attributes, so you'd end up with something like this?

rabbitmq_vhost { 'myvhost':
  ensure             => present,
  tags               => ['myvhost tags'],
  default_queue_type => 'quorum',
}

from puppet-rabbitmq.

That works for me. Is there anyone specific you suggest I should ask for feedback>

from puppet-rabbitmq.

The other question is should we make quorum queues the default queue type if not specified. Currently RMQ defaults to Classic Queues, but these will be removed in RMQ 4 so does it make more sense to make it the default in the module now. Or do a version check to decide which to use as default?

from puppet-rabbitmq.