voxpupuli / puppet-poudriere Goto Github PK

While working on #51, I spotted a bunch of things that where beyond the scope of this PR but where annoying / weird for me, so I open this issue to list these points so that maintainers can tell what they thing about it and we can track the overall progress.

Here is a checklist of the things I spotted and am willing to fix. I propose to have these items checked when the maintainers are OK with it, then add a link to a PR when one is ready, and strike-out the lines when the PR are merged.

• #51 (merged) — Add data-types for all parameters
• #53 (merged) — The module use default values of '' for optional values… Change these to undef and use a Optional[String[1]] data type for these items
• poudriere::zpool default value is currently tank, a term commonly found with ZFS but is the name of the pool the end-user want sot use only when they are super-lucky… Maybe it's worth change it:
  • #53 (merged) — default poudriere::zpool to undef (do not set a default value, poudriere can work without ZFS (at least, support for this was added at some point))
  • (abandoned) default poudriere::zpool to zroot (default pool name when installing FreeBSD with ZFS on root)
• #56 (merged) — poudriere::freebsd_host default to a specific mirror, change it to http://ftp.FreeBSD.org/, which is made up of many machines operated by the project cluster administrators and behind GeoDNS to direct users to the closest available mirror
• #54 (merged) — The default version of env::architecture is hardcoded to amd64. Default to the architecture of the node.
• #57 (merged) — The default version of env::version is hardcoded to an old release. Default to undef and force the user to specify explicitly what version they want.
• #58 (merged) Sync configuration file parameters with latest poudriere settings
• #61 Switch from ERB to EPP
• #58 (1/2, merged), #59 (2/2, merged) — Extend the test suite with tests that set all parameters (we seem to have some parameters which lead to broken catalogs when used)

as of the latest version, there seems to be an error in env.pp

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Syntax error at '['; expected ']' at /etc/puppet/environments/production/modules/poudriere/manifests/env.pp:41 on node nj1ipinfra001.fxcorp
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

It would be nice if this module would support setting package options (manage options files). Data could be retrieved from hiera.

In init.pp manifest you have a block[1] indicating that cron_enable and cron_interval have been deprecated. however these values are both required for the default portstree[2]. can the old parameters be renamed to portstree_default_cron_enable and portstree_default_cron_interval?

[1]https://github.com/xaque208/puppet-poudriere/blob/master/manifests/init.pp#L71-L77
[2]https://github.com/xaque208/puppet-poudriere/blob/master/manifests/init.pp#L82-L87

Error from puppet:

debug: Executing '/usr/local/bin/poudriere ports -c -m svn'
err: /Stage[main]/Poudriere/Exec[create default ports tree]/returns: change from notrun to 0 failed: /usr/local/bin/poudriere ports -c -m svn returned 1 instead of one of [0] at /etc/puppet/environments/freebsd/modules/poudriere/manifests/init.pp:40

Running manually

# /usr/local/bin/poudriere ports -c -m svn
====>> Error: Unknown value for USE_TMPFS can be a combination of wrkdir,data,all,yes,localbase

This seems to be because the default "YES" is not a valid input. From the config file:

# Use tmpfs(5)
# This can be a space-separated list of options:
# wrkdir    - Use tmpfs(5) for port building WRKDIRPREFIX
# data      - Use tmpfs(5) for poudriere cache/temp build data
# localbase - Use tmpfs(5) for LOCALBASE (installing ports for packaging/testing)
# all       - Run the entire build in memory, including builder jails.
# yes       - Only enables tmpfs(5) for wrkdir
# EXAMPLE: USE_TMPFS="wrkdir data"
USE_TMPFS=YES

Perhaps the default should be "yes"?

Report from Puppet shows that symlinks are not supported:

Warning: Symlinks in modules are unsupported. Please investigate symlink zleslie-poudriere-0.1.3/spec/fixtures/modules/poudriere/manifests->../../../../manifests.
Warning: Symlinks in modules are unsupported. Please investigate symlink zleslie-poudriere-0.1.3/spec/fixtures/modules/poudriere/templates->../../../../templates.

I'm sure duplication of files are not optimal, however it appears that per Puppet v3.7.1 this isn't supported.