pragmatic-pbr's People
Forkers
mcanthony realitix bradparks shadercoder vongoethe deniszatsepin grimor hsab wighawag pclod lp249839965 blockspacer jonike naming1086 dslming luyufanzhipragmatic-pbr's Issues
Some hickups when trying to run the first example
I started following your tutorial here: http://marcinignac.com/blog/pragmatic-pbr-setup-and-gamma/
I've noticed the following things which made me scratch my head after (1.) pulling the repo & (2.) doing an npm install
.
Tried to run the beefy command. Beefy not found
. So I did: npm install -g beefy
, I also installed browserify globally, not exactly sure if this was necessary.
Then I ran the beefy command again. Threw me an error: Cannot find module 'glslify-promise/transform'
. I then did: 'npm install glslify-promise` locally in the project folder.
Hope it helps to make the tutorial clearer ;)
Running 202-lambert-diffuse for the first time
Error: Cannot find module 'C:Users�983Downloadspragmatic-pbr-masterpragmatic-pbr-master
ode_modules_glslify-promise@[email protected]' from 'C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\202-lambert-diffuse'
at C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:46:17
at process (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:173:43)
at ondir (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:188:17)
at load (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:69:43)
at onex (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:92:31)
at C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:22:47
at FSReqWrap.oncomplete (fs.js:154:21)
Running 201-init for the first time
I had a few issues minor getting the first sample running.
Pes-context wasn't in the package.json file so I added it.
"pex-context": "variablestudio/pex-context",
and then 201-init\main.js did not include an 'init' function, so the loaded page would fail:
Window.js:304 Uncaught TypeError: window.init is not a function
Adding an empty init function to the object passed to Window.create solves the problem.
init: function() {
},
Thanks
Two small issues
This shader is not going from srgb -> linear. But maybe it's alright if the equirectangular image was exported linear?
https://github.com/vorg/pragmatic-pbr/blob/master/305-exposure-basic/Reflection.frag
Another small bug - the uncharted2 tonemap is operating on gl_FragColor instead of the color parameter.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.