vorg / pragmatic-pbr Goto Github PK

I started following your tutorial here: http://marcinignac.com/blog/pragmatic-pbr-setup-and-gamma/
I've noticed the following things which made me scratch my head after (1.) pulling the repo & (2.) doing an npm install.

Tried to run the beefy command. Beefy not found. So I did: npm install -g beefy, I also installed browserify globally, not exactly sure if this was necessary.

Then I ran the beefy command again. Threw me an error: Cannot find module 'glslify-promise/transform'. I then did: 'npm install glslify-promise` locally in the project folder.

Hope it helps to make the tutorial clearer ;)

Error: Cannot find module 'C:Users�983Downloadspragmatic-pbr-masterpragmatic-pbr-master
ode_modules_glslify-promise@[email protected]' from 'C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\202-lambert-diffuse'
at C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:46:17
at process (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:173:43)
at ondir (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:188:17)
at load (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:69:43)
at onex (C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:92:31)
at C:\Users\17983\Downloads\pragmatic-pbr-master\pragmatic-pbr-master\node_modules_resolve@1.1.7@resolve\lib\async.js:22:47
at FSReqWrap.oncomplete (fs.js:154:21)

I had a few issues minor getting the first sample running.

Pes-context wasn't in the package.json file so I added it.

      "pex-context": "variablestudio/pex-context",

and then 201-init\main.js did not include an 'init' function, so the loaded page would fail:

Window.js:304  Uncaught TypeError: window.init is not a function

Adding an empty init function to the object passed to Window.create solves the problem.

    init: function() {
    },

Thanks

This shader is not going from srgb -> linear. But maybe it's alright if the equirectangular image was exported linear?
https://github.com/vorg/pragmatic-pbr/blob/master/305-exposure-basic/Reflection.frag

Another small bug - the uncharted2 tonemap is operating on gl_FragColor instead of the color parameter.