voku / html2text Goto Github PK

I am getting this error:

• Undefined index: mbstring.

The way I fixed was adding:

self::checkForSupport();

at the beginning of html_entity_decode function (line 2444 of the UTF8.php file).

Is this the best way to fix?

thanks!

thank you for your libraries! just awesome

Hi,

Firstly wanted to say thanks for your great work in extending the use of this library!

My question is about ordered lists: I would like to be able to display them as follows:

1. Item one
2. Item two
3. Item three

instead of using asterisks for each list item. Is this possible?

It returns just Array on a page, instead of a text version of the text on URL provided.

There is a LICENSE file, which is a GPL v. 2, plus some badly formatted extra advertising clause talking about commands and stuff.

Looks like something got very badly copy-pasted carelessly.

I strongly suggest against any of that:

1. Adding clauses to the GPL is strongly against both the spirit of the GPL itself, and senseless, because it will make your software incompatible with the real GPL (so why use it in the first place)
2. Why version 2? Why not "or any later version"? Is that intentional? I assume that's another mistake.
3. Why the GPL in the first place? It's an extremely poor choice for such a library. Just go with a permissive license instead, such as MS-PL or BSD. Or, if you really want to be a pain, AGPL is what you want. GPL is just senseless for something meant to run on a server.
4. Are you sure you have the right to re-license the original software? It wasn't licensed at all, AFAIK. Which is already a non trivial problem.

print (new Html2Text('<P>Test string</P>'))->getText();

prints nothing while

print (new Html2Text('<p>Test string</p>'))->getText()

prints Test string as expected.

The reason for that is in \voku\Html2Text\Html2Text::pregCallback.
$matches['element'] is initially converted to lowercase with

$element = \strtolower($matches['element']);

but the lowercase version is not used in the switch statement or to match headings:

protected function pregCallback(array $matches): string
    {
        // init
        $element = \strtolower($matches['element']);

        switch ($matches['element']) { // Case sensitive
            case 'p':
                // Replace newlines with spaces.
                $para = \str_replace("\n", ' ', $matches['value']);

                // Add trailing newlines for this paragraph.
                return "\n\n" . $para . "\n\n";
                ...
                ...
        }

        // h1 - h6
        if (\preg_match('/h[123456]/', $matches['element'])) {  // Case sensitive
            return $this->convertElement($matches['value'], $matches['element']);
        }

I don't understand why pregCallback returns an empty string as last line.
Shouldn't the code always know how to handle the $matches['element'] that ends up in pregCallback?
Wouldn't it be better to throw an exception in case there is no handling available for a match $matches['element']
or return $matches['value'] ?? ''?