voker57 / qmpdclient Goto Github PK

QMPDClient used to work, but after my last "mpc update" I can't connect to my local mpd, bacause qmpdclient crashes with: "ASSERT: "d->artistAlbumMap.contains(artist)" in file ~something/qmpdclient/src/mpdcache.cpp, line 149".
I cleaned the playlist, deleted (even purged) qmpdclient, which didn't helped.
I tryed (both hand compiled) current git and stable 1.1.3 on a debian squeeze, the music is located on ext4 while the config files are on ext3 (I'll update this partition later).

Could it please obey CD numbers when ordering tracks? And could it show them on the playlist?

I couldn't find a way to add a song to one of my playlists (the ones which are listed on Playlists tab). Drag'n'drop doesn't work, and there's no context menu option.

I hope I didn't overlook the possibility to do so. I use QMPDClient 1.2.2 and mpd 0.18.8 on Arch.

Hi,
I'd like to use this player on a netbook with the resolution 1024x768.
I've got the Problem that I'm not able to see and use the complete gui.
At the bottom the Gui gets cutted by the end of the screen and the task bar.

Could this get fixed?

In the console:

content-type missing in HTTP POST, defaulting to application/octet-stream

And also, every time I open QMPDClient it tries to dispatch a batch of scrobbles and fails with this error in the statusbar ( which I had to scrape through strace to find )

348083 read(13, "HTTP/1.1 200 OK\r\nServer: Apache-Coyote/1.1\r\nPragma: no-cache\r\nCache-Control: no-cache\r\nContent-Type: text/plain;charset=ISO-8859-1\r\nDate: Tue, 29 May 2012 18:35:19 GMT\r\nTransfer-Encoding: chunked\r\nConnection: close\r\n\r\n4b\r\nFAILED Plugin bug: Not all request variables are set - no POST parameters.\n\r\n0\r\n\r\n", 304) = 304

And working up a bit higher I can find the request that was sent off

348083 write(13, "POST /protocol_1.2 HTTP/1.1\r\nContent-Length: 23045\r\nConnection: Keep-Alive\r\nAccept-Encoding: gzip\r\nAccept-Language: en-NZ,*\r\nUser-Agent: Mozilla/5.0\r\nHost: post2.audioscrobbler.com:80\r\nContent-Type: application/octet-stream\r\n\r\n", 227) = 227
...
348083 write(13, "s=1fd935dc6c4a404db2d4ee629c0c2205&r[0]=&m[0]=&a[0]=Dieselboy&o[0]=P&t[0]=We%20Want%20Your%20Soul%20%28Raiden%20Remix%29&b[0]=Substance%20D&l[0]=234&i[0]=1337855869&n[0]=7%2F17&r[1]=&m[1]=&a[1]=Johnny%20Cash&o[1]=P&t[1]=My%20Shoes%20Keep%20Walking%20Back%20To%20You&b[1]=Love%2C%20God%2C%20Murder&l[1]=143&i[1]=1337856057&n[1]=13%2F16&r[2]=&m[2]=&a[2]=Ruff%20Ryders&o[2]=P&t[2]=Weed%2C%20Hoes%2C%20Dough&b[2]=Ryde%20Or%20Die%20Vol.%202&l[2]=240&i[2]=1337856195&n[2]=07&r[3]=&m[3]=&a[3]=Nirvana&o[3]=P&t[3]=Turnaround&b[3]=Incesticide&l[3]=139&i[3]=1337856497&n[3]=5&r[4]=&m[4]=&a[4]=_no_artist_&o[4]=P&t[4]=Track%2007&b[4]=80%27s&l[4]=298&i[4]=1337856636&n[4]=7%2F19&r[5]=&m[5]=&a[5]=Jesus%20Lizard&o[5]=P&t[5]=Shut%20Up&b[5]=Jesus%20Lizard&l[5]=71&i[5]=1337856930&n[5]=00%20-%20Shut%20Up&r[6]=&m[6]=&a[6]=Madonna&o[6]=P&t[6]=What%20It%20Feels%20Like%20For%20A%20Girl&b[6]=Music&l[6]=284&i[6]=1337856996&n[6]=8&r[7]=&m[7]=&a[7]=Johnny%20Cash&o[7]=P&t[7]=One&b[7]=American%20III%3A%20Solitary%20Man&l[7]=233&i[7]=1337857275&n"..., 16384) = 16384
...
348083 write(13, "[112]=Salmonella%20Dub&o[112]=P&t[112]=Johnny&b[112]=Killervision&l[112]=282&i[112]=1337900006&n[112]=7&r[113]=&m[113]=&a[113]=Korn&o[113]=P&t[113]=Freak%20On%20A%20Leash&b[113]=Follow%20The%20Leader&l[113]=255&i[113]=1337900288&n[113]=14%2F25&r[114]=&m[114]=&a[114]=Johnny%20Cash&o[114]=P&t[114]=Cold%20Shoulder%20%28Master-Take%201%29&b[114]=The%20Man%20In%20Black%20I%20%281954-1958%29&l[114]=135&i[114]=1337900544&n[114]=21%2F21&r[115]=&m[115]=&a[115]=Loreena%20McKennitt&o[115]=P&t[115]=Lullaby&b[115]=Elemental&l[115]=268&i[115]=1337900674&n[115]=9&r[116]=&m[116]=&a[116]=Coldplay&o[116]=P&t[116]=Twisted%20Logic&b[116]=X%26Y&l[116]=302&i[116]=1337900937&n[116]=12&r[117]=&m[117]=&a[117]=John%20Denver&o[117]=P&t[117]=High%2C%20Wide%20And%20Handsome&b[117]=Flower%20That%20Shattered%20the%20Stone&l[117]=201&i[117]=1337901234&n[117]=4&r[118]=&m[118]=&a[118]=Rammstein&o[118]=P&t[118]=Spieluhr&b[118]=Muttertag&l[118]=113&i[118]=1337901431&n[118]=5%2F32&r[119]=&m[119]=&a[119]=Johnny%20Cash&o[119]=P&t[119]=In%20The%20S"..., 6661) = 6661

I have reason to believe it may be related to http://code.google.com/p/qmmp/issues/detail?id=526&can=1&q=POST&colspec=ID%20Type%20Status%20Priority%20Summary%20Stars

"This is a change that appears when Qt 4.8.0 is used, as this version does not set the default Content-Type to application/x-www-form-urlencoded by default anymore. You have to call setKnownHeader() on the QNetworkRequest prior to post/get'ing it." ( http://qt.gitorious.org/qt/qt/commit/2a6d7fcde4092f41230841bbe4c078f2e42166bb/diffs )

Which makes sense as I'm using Qt 4.8.1

[ 55%] Building CXX object CMakeFiles/qmpdclient.dir/src/playlistpanel.cpp.o
/usr/bin/x86_64-pc-linux-gnu-g++ -DWITH_DBUS -DQT_XMLPATTERNS_LIB -DQT_GUI_LIB -DQT_DBUS_LIB -DQT_XML_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DNAMEVER=""QMPDClient 9999"" -DPREFIX="/usr" -DVERSION="9999" -DNDEBUG -O2 -pipe -I/usr/include/qt4 -I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtDBus -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtCore -I/var/tmp/portage/media-sound/qmpdclient-9999/work/qmpdclient-9999_build -I/var/tmp/portage/media-sound/qmpdclient-9999/work/qmpdclient/src -o CMakeFiles/qmpdclient.dir/src/playlistpanel.cpp.o -c /var/tmp/portage/media-sound/qmpdclient-9999/work/qmpdclient/src/playlistpanel.cpp
/var/tmp/portage/media-sound/qmpdclient-9999/work/qmpdclient/src/playlistpanel.cpp: In member function ‘void PlaylistPanel::updateFilter(const QString&)’:
/var/tmp/portage/media-sound/qmpdclient-9999/work/qmpdclient/src/playlistpanel.cpp:57:53: error: invalid use of incomplete type ‘struct PlaylistModel’
/var/tmp/portage/media-sound/qmpdclient-9999/work/qmpdclient/src/playlistview.h:27:7: error: forward declaration of ‘struct PlaylistModel’

Feature Request: Would be nice to have a function to add streams from the shoutcast directory to the web radio tab.

qmpdclient/src/libmpdclient.c:452]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

while((ret = select(connection->sock+1,NULL,&fds,NULL,&tv)==1) ||

Maybe better code

while(((ret = select(connection->sock+1,NULL,&fds,NULL,&tv)) == 1) ||

qmpdclient/src/libmpdclient.c:533]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

if((err = select(connection->sock+1,&fds,NULL,NULL,&tv) == 1)) {

Duplicate.

I am moving release zips out of repository into GitHub releases. Along with physical move I also plan to purge them from Git history thus rewriting it completely. Let me know if this affects your fork.

Feature Request: Possibility to search through the shoutcast directory.

It would be nice to have a possibility to sort the music library by genre tag.

For example, I want to listen to genre X, but not to a specific band/artist/album to simply select genre X and then browse through the artists/albums tagged with that genre.

In some earlier version of qmpdclient this was possible, as far as I can remember, but as the option to select "Artist: All" was removed it became impossible to use the "Song filter" to search over the whole library.

My idea would be to eventually "redesign" the filter processing. I think that three colums would be enough, but it would be nice to select via "drop-down" what filters I want to have in which fields. For example to have on the Artist and Album filter the possibility to change this via dropdown to Genre and Year.

Sometimes it happens to me that I'm not able to remember the album title/artist but know some different facts on a song. But filtering with different information is not really easy in qmpdclient.

This would just be an idea, and possibly needs some more discussion what would be good and fast too. Possible that there is already a good way to handle such "requests" but I can't see it right now.

Thanks in advance and kind regards,
Harald Gutmann

$ identify icons/64x64/qmpdclient.png 
icons/64x64/qmpdclient.png PNG 60x61 60x61+0+0 8-bit DirectClass 2.25KB 0.000u 0:00.000

It's probably a good idea to remake the icon from svg or just add the proper amount of transparent pixels at proper sides.

First off, thanks for keeping up the work on QMPDClient. It's a very
nice client, and my first choice for my day-to-day requirements.

I think I may have found a bug. Here's what happened:

I have copied a lot of new files to my music directory and ran an update
on it with "mpc --wait update" (rescanning from within QMPDClient didn't
seem to do anything). Within these new files were some songs of an
artist of which I already had an album in my collection, with only a
slight difference in spelling of the artist's name ("Iron and Wine" vs.
"Iron And Wine").

After the update, I could only find the (new) songs under "Iron and
Wine" (lower-case "and"). The old songs wouldn't show up, as the other
spelling "Iron And Wine" (upper-case "And") is not found/shown anymore
in QMPDClient.

I used mpc and quimup to check my database validity, and those two show both
spellings as separate entries and hence I can access all of the songs.

These are the versions I used:
QMPDClient (latest git snapshot
429c5ef, but was the same with a git
version from 2012-10-13)
mpd 0.17.1
mpc 0.22 (for running the update)
quimup 1.3.0 (for comparison)

Let me know if more information is required. Thank your for your time!

When clicking MPD > Locate Current Song, the playing song is highlighted in the library view, but the active playlist. It would be helpful to have the playlist jump to the song as well, to see what's coming up next, etc. Currently, the only way to do this is to manually scroll through the playlist; even searching for it returns to the previous selection when the search is cleared.

The Lyrics window shows only "Upgrade to Lyrics Plugin version 0.4".

There are no alternative skins provided in installation, there are no easily findable skins online and I can't find any documentation detailing how to make your own. Any chance for at least a guide as to how to make your own - ideally with a copy of the dark green skin visible in the screenshots on the website as an example?

After upgrade from 1.1.0 to 1.1.2 (1.1.1 also affected) qmpdclient does not show directory tree (only Root without subdirs). Also in Library view exists only artist list, albums and track lists are empty. But playlist view works correctly, as a radiostation view.

mpd ver 0.15.8
all compiled for i686
Qt version 4.6 (under 4.5 bug also exist)
mpc/ncmpc works as intended