vmware-archive / jsunit Goto Github PK

I reported this previously, but thought I'd give the new 2.2 release a try. Still not working with IE 8. It runs, and if all tests pass things are OK. If any test fails IE always reports "Object doesn't support this property or method". Not helpful. I believe this has to do with the way JsUnit throws exceptions to collect failures. IE 8 seems to have changed its exception handling where exceptions cannot be throw across frames.

In the meantime I've been playing with JSpec, and having success with that in IE 8.

It would make it so much easier to reach the problematic tests and inspect them.

IE8 doesn't allow you to check to see that a property is undefined, rather it fails with an error since you tried to access an undefined property and pass it to the assertUndefined function.

Code

assertObjectEquals(
    'Why this works?',
    {},
    {'hey': 1}
);

assertObjectEquals(
    'And this too???',
    {'hop': 3},
    {'hey': 1}
);

assertObjectEquals(
    'Only here we are normally stop.',
    {'hey': 2},
    {'hey': 1}
);

JsUnit 2.2

User-agents

• Running on Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.9.0.15) Gecko/2009101601 Firefox/3.0.15
• Running on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/530.5 (KHTML, like Gecko) Chrome/2.0.172.33 Safari/530.5
• Running on Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)

version 2.2, in jsUnitCore.js, assertObjectEquals(date1, date2) failed to compare two equivalent Date objects.

The cause is in the same file,
JsUnit.PRIMITIVE_EQUALITY_PREDICATES

A quick solution follows.

1. Add the following:
   JsUnit.DATE_EQUALITY_PREDICATE = function(var1, var2) {
   return var1.valueOf() === var2.valueOf();
   };
2. Modify the following line
   'Date': JsUnit.TRIPLE_EQUALITY_PREDICATE,
   to the following line
   'Date': JsUnit.DATE_EQUALITY_PREDICATE,

Please review the solution.