Giter Club home page Giter Club logo

react-konami-code's Introduction

react-konami-code's People

Contributors

benzleung avatar eliamartani avatar friemt avatar mechamobau avatar thecampagnards avatar vitorluizc avatar vmarchesin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

react-konami-code's Issues

Cannot find module: 'react-konami-code' with 1.2.2

I upgraded to ^1.2.2, and this broke my production build.

The error is:

> [email protected] build-js /data
> react-scripts build

Creating an optimized production build...
Failed to compile.

./src/components/CustomLayout/CustomLayout.js
Cannot find module: 'react-konami-code'. Make sure this package is installed.

You can install this package by running: npm install react-konami-code.

However react-konami-code is set in my dependencies in package.json, and is in node_modules folder.

node_modules/react-konami-code:
total 24
-rw-r--r-- 1 deploy-build deploy-build  350 Oct 26  1985 CHANGELOG.md
-rw-r--r-- 1 deploy-build deploy-build 1072 Oct 26  1985 LICENSE
-rw-r--r-- 1 deploy-build deploy-build 3740 Oct 26  1985 README.md
drwxr-xr-x 2 deploy-build deploy-build 4096 Nov 30 17:51 dist
-rw-r--r-- 1 deploy-build deploy-build 2219 Nov 30 17:51 package.json
drwxr-xr-x 3 deploy-build deploy-build 4096 Nov 30 17:51 test

Any idea about this error?

Your last commit is:

Fix third party vulnerabilities

How risky is it to continue using v1.2.0? Cause it works fine.

Change CJS export to ESM

Hi there, great project!
While I was trying to use the package, I couldn't manage to get it to work with a custom element (not plain text), e.g.

<Konami>
    <MyElement/>
</Konami>

I'm using Vite, and while it worked in development mode, it didn't work when I compiled to production, so it might be a problem with rollup.

Thanks!

react, react-dom and prop-types shouldn't be dependencies

I've upgraded to [email protected] and got an Invalid hook call error on useKonami.

Screenshot with "Invalid hook call" error

Seems like this package requires react and react-dom as dependencies.

npm ls react
[email protected] /home/vitorluizc/projects/trybe/student-journey-client
├── UNMET PEER DEPENDENCY [email protected] 
└─┬ [email protected]
  └── [email protected] 

npm ERR! peer dep missing: react@^0.14 || ^15 || ^16, required by [email protected]
npm ERR! peer dep missing: react@^16.0.0, required by [email protected]
npm ERR! peer dep missing: react@^16.8.0, required by [email protected]
npm ERR! peer dep missing: react@^16.13.1, required by [email protected]
npm ERR! peer dep missing: react@^0.14.7 || ^15.0.0 || ^16.0.0, required by [email protected]
npm ERR! peer dep missing: react@^0.14.0 || ^15.0.0 || ^16.0.0, required by [email protected]

But it shouldn't. react and react-dom should be required in peerDependencies, and just imported as devDependency if you need to run tests, example etc.

It also throws an error because React.js 17 don't match react peer dependency range. But it doesn't seem to break with it.

"peerDependencies": {
"react": "^16.13.1",
"react-dom": "^16.13.1"
}

Option to reset

Hi

Can you add the option to reset and hide the element again?

I have an issue where I have a box that pops up. but when I close out of the box, I cant get it to reopen when the code is called as it already thinks its visible

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.