vjftw / please-nodejs Goto Github PK

As we're only generating a package.json and using the metadata from sub-packages, pnpm install ... tries to find and install the latest versions of packages which it can't as it has no internet-access. This is pretty major and frustrating bug as it forces you to update dependencies.

The solution to this, is to generate a package-lock.json and use npm clean-install which installs packages from the package-lock.json. Generating the package-lock.json appears non-trivial right now due to my limited experience, but i'll revisit when I get a chance. For now, I recommend just using the node_toolchain in a genrule like this to install packages and committing your package.json + package-lock.json.

I've pushed a new release (v0.0.5) as a really crappy workaround to this which is to remove the sandboxing from the nodejs_package_json node_modules subrule which will allow newer dependencies to be installed (breaking the guarantees that Please provides).

In order to keep development workflows fast and simple, we should remove the current _serve subrule introduce:

• A dev_cmd used for a set of _dev_* subrules.
• A _dev subrule which executes the dev_cmd which can be development server related. We need to make sure that users disable the automatic reload of dev servers and in favour of using plz watch --run ... instead.

ESBuild supports this: https://how-to.dev/how-to-set-up-a-dev-server-with-esbuild

The install command was implemented under the expectation that NodeJS packages do not have dependency cycles. When trying to install eslint-plugin-react, we end up in a loop. We should only add new packages the queue if they haven't already been added to the queue by keeping state of all packages.

Acceptance criteria:

• gentest for running unit tests.