codes-youtube-videos's Issues
merge two sorted linked list.cpp BUG
Hi, I saw your video on the merge of two sorted list. The algorithm will not work in one edge case
Since at the beginning you are setting s, p and q the algorithm assumes that in the lists there are at least 2 nodes. It will not work if one of the lists contain 1 node only as the p pointer will be set to null and so it will print that single node only. The second list will be lost
Please double check and rectify
When you initialise you need to check if one of the lists have a single node. In that case you would need to create the link from that single node to the other list and the algorithm will terminate immediately without the nedd to continue
For this I believe you need to add this check
if(p.next === q || q.next === p) return newHead
after you have properly initialised the p, q and s based on this edge case
if(p && q){
if(p.val <= q.val ) {
s = p
**if(p.next) {
p = p.next
}
else {
p.next = q
}**
} else {
s = q
**if(q.next) {
q = q.next
} else {
q.next = p
}**
}
in bold the missing checks
Thanks
sir help me please
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.