viur-framework / flare Goto Github PK

details and summary are currently not implemented as widgets.

This ViUR bone definition

	entry_id = numericBone(
		descr="Nummer",
		unique=UniqueValue(UniqueLockMethod.SameValue, True, "Nummer muss eindeutig sein!"),
		indexed=True,
		searchable=True,
		defaultValue=None,
		min=0
	)

is not required, and therefore should accept nothing as valid value. But the widget always resets the number to "0", which is invalid:

There used to be a gen-files-json.py utility script in the bin folder, which was removed, and the functionality moved over to the tools/flare.py script. However, this functionality is not directly exposed yet.

Please make the files.json generation available again.

This is a feature-request for implementing slots.

To implement such components

<popout icon="icon-arrowhead-down">
	<popout-item @click="onEdit">edit</popout-item>
	<popout-item @click="onLeave">leave</popout-item>
	<popout-item @click="onDelete">delete</popout-item>
</popout>

It would be nice to have slots, where the content of the popout will be inserted, like this:

<flare-icon [name]="icon" hidden></flare-icon>
<span [name]="text" hidden></span>

<div class="popout">
        <div [name]="popoutItemList" class="list">
                  <slot><!-- Default Content --></slot>
        </div>
</div>

From Vue.js there is also an extension for named slots. These should be considered as well.

While working with flare on master feauture/next branches it is not evident, which type parameters should have in several methods / cases. I would be proud to work on that topic.

Likewise v-for in Vue.js, flare should allow for a list-rendering method flare-for. This can only be achieved properly when fromHTML.replaceVars() provides a way to access sub-classing elements, delimited by the dot notation, like

<ul flare-for="animal in animals">
    <li class="animal-{{animal.livingspace}}">{{animal.name}}</li> 
</ul>

This is very dangerous: https://github.com/mausbrand/flare/blob/df94e1d448d9280a40048c1d3d4974929dcc7485/flare/forms/formatString.py#L110
As it's currently used (.textContent i'd guess) that will lead to invisible text after an < in a stringBone; if it's ever used with .innerHtml etc. you have an xss injection in the vi. Better strip format tags from textBones instead.

• html5
  • Cleaning up several issues (no ignite-specific classes)
• Network handler
• Event handler
• Priority queue
• Request handler?
• Ignite
  • embedsvg Icon manager (including reference generator)
  • Button
• More Popup dialogs
  • flare.popup.Error
  • flare.popup.Warning
  • flare.popup.Confirm
• ViUR Integration
  • Forms
  • Module handlers
    • Generic filters / search
    • List selector
    • Tree selector
    • Customizable Image / File uploader

A special <widget>-Tag could be used to identify the current html5.Widget-subclass.

class MyText(html5.Span):
    def __init__(self):
        super().__init__(
            """
            <widget class="big" title="Hahaha">
                Hello My Text
            </widget>
            """

would result in

<span class="big" title="Hahaha">
    Hello My Text
</span>

The special <widget>-Tag should only be allowed at top-level of the Template.

When a template is rendered by flare, it is being parsed into an object tree. The corresponding class for SVG paths is this one which only supports the two attributes d and pathLength. The standard lists quite a lot more attributes, but they all get discarded by this parsing process, resulting in visually broken SVG being rendered.

Currently, when html5.Widget.hide() or html5.Widget.show() is used, the display-state is changed as inline-CSS.
This is not wanted in a pure ignire/flare setup, where only a CSS-class "is-hidden" should be added, but may be wanted in a setup without using ignite as CSS. The html5 library on its own should be usable out-of-the-box without having to use pre-defined CSS-classes.

Because html5.Widget is the ultimate base class of ALL HTML-Widgets, we cannot directly subclass it in flare, so we have 3 options:

a) Hard-code the "is-hidden" class into html5.Widget.hide(), html5.Widget.show(), html5.Widget.isHidden()
b) Monkey patch html5.Widget.hide(), html5.Widget.show(), html5.Widget.isHidden() inside flare
c) Make the behavior configurable via flare.conf. This one would have much unnecessary runtime overhead to check for and add or remove various classes, or fallback to the inline style.