vite-pwa / vitepress Goto Github PK

extract index module logic to vitepress module

pnpm install -D @vite-pwa/vitepress

 WARN  Issues with peer dependencies found
.
└─┬ @vite-pwa/vitepress 0.0.5
  └── ✕ unmet peer vite-plugin-pwa@^0.14.0: found 0.15.1

https://github.com/vite-pwa/vitepress/blob/d5d62c8e0e8d40491341d591f7467c96dac92fd9/package.json#LL46C21-L46C21

• Visit https://vite-pwa-org.netlify.app/not-found
• Click Get Started
• 

So do Vue Macros, VueUse

and remove local copy with the transformHead PR

not working in pwa-prompt example, there is no client build!

EDIT: we should check if adding a custom plugin removing the ssr check (on pwa build plugin) works (it should work: we're getting the api reference using mpa flag)

the hero image should be for VitePress, like the title: Zero-config PWA Plugin for VitePress

@antfu do you like that change? If so, can you change/provide the hero image?

Describe the bug

When I add some url params such as ?a=1&b=2 after the page's URL, the console log an error Hydration completed but contains mismatches. and the page rendering is incorrect

Reproduction

1. Clone from https://github.com/GlobeMC/crashmc.com
2. pnpm install && pnpm run docs:build && pnpm run docs:preview
3. Access http://localhost:4173/client/system.html and http://localhost:4173/client/system.html?someparam=somevalue
4. The page without param will works well, but the page with the URL param will somehow mixed with the home page's content

OR

Just access https://vite-pwa-org.netlify.app/guide/register-service-worker.html?

Expected behavior

The two pages should looks exactly same.

Some information at vuejs/vitepress#3469

We need:

• modify injectRegister to be 'virtual' | 'script' | 'inline': defaults to script?
• inject webmanifest in VitePress head: we need to handle dev or build mode
• inject registerSW.js or inline code to register the sw when injectRegister !== 'virtual' (if using virtual, just ignore it)
• add example with prompt: requires SFC (quite simple)

we should also add gh funding and actions