vitalliuss / aircompany Goto Github PK
View Code? Open in Web Editor NEWProject with "code smells" for refactoring
License: MIT License
Project with "code smells" for refactoring
License: MIT License
Soy de la universidad Espol del Ecuador y como tarea nos mandaron a buscar repositorios a los cuales identificar los code smells y hacer refactoring. Me parece haber encontrados unos en su codigo.
1.- Speculative Generality
Esto es porque existe una clase que no se usa, que no hace nada, en este caso la clase MyPlane, que no posee meotodos. Es innecesaria en el momento
Refactoring : Utilizaremos Collapse Hierarchy para eliminar la clase que no es necesaria, mezclarla con la superclase. En este caso MyPlane solo tiene el constructor que es igual al de Plane, por lo que solo eliminaremos la clase.
2.- Primitive Obssesion
Ocurre cuando se usa un dato primitivo en vez de objetos pequeños. En este caso usa un string para Modelo, el cual debería ser una clase la cual oodria tener mas cualidades que solo el nombre del modelo.
Refactoring : En este caso usaremos Replace Data Value with Object, lo que nos permitirá crear una nueva clase modelo y pasarle a la clase Plane el objeto modelo y no el dato primitivo String modelo.
Hello, i was checking the code and this are the code smells that i found so far.
Code Smell: Speculative Generality
Exist a clase call "My plane" and it doesnt do anything. it should be remove.
Code Smell: Alternative Classes With different interfaces
I think that you can add a interface for the methods toString(), hashcode() and equals().
Hope that this is correct and helpful.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.