visualcomposer / visual-composer-starter Goto Github PK

Bullets should be styled for all depths.

VC_Customizer -> VCT_Customizer
vc_get_sidebar_class -> vct_get_sidebar_class
...

Check ALL namings

re-check codestyle some places have FALSE and TRUE uppercase style
also theme version 1.0 but in php classes sometimes @SInCE 1.1, can be confused in future
in many places mixed YODA condition comparison
if ( get_theme_mod( 'vc_header_sandwich_style', '#333333 ' ) == '#FFFFFF ' ) {
if ( 'div' === $args['style'] ) {
better to consider same style for comparison
always use === instead of ==
missed space in 'footer-'.$i and other operators sometimes have missed space (please use PHPCS)
Follow code style https://codex.wordpress.org/WordPress_Coding_Standards

Better to use package.json for third-party libs. More easy to update and control version of the lib

js/collapse.js
js/slick.min.js

We compressed screenshot file as the current one is really big.

When Custom Excerpt is entered in post it should be outputted on archive pages instead of the excerpt generated from the post content

We need to rename theme so the title is applicable for WP. Name it: Visual Composer Starter and ensure that it is changed in all places.

In design submenu arrow in sandwich is smaller. See screenshot and design screenshot:

P.S. I like location change you made

Right after activation I'm seeing this error on frontend:
Strict Standards: Non-static method VC_Fonts::vc_theme_google_font_variants() should not be called statically in /Users/mmihey/Sites/test/wp-content/themes/visual-composer-theme/inc/customizer/vc-fonts.class.php on line 113

Change Widgets section structure according to schema/design in attachment. Combine Footer Widgets into group.

Pay attention to naming.
Customizer-Widgets.zip

Users sometimes copy link without http:// - we need to make validation, if user did not enter http:// or https:// then prepend //

otherwise WP thinks it is relative URL

I played with buttons and upon choosing Capitalization it did not work

Please Scope all JavaScript files to localscope
inc/customizer/js/control-toggle-switch.js
inc/customizer/js/control-image-select.js
(function($){
// Local
})(window.jQuery)

Or refactored as single object if this code can be used in other js files

http://wpengineer.com/2358/enqueue-comment-reply-js-the-right-way/

Sandwich style: Light and Dark must also affect sandwich background color, with dark as default (see design). This control affects sandwich icon (menu and close and background)

Rename Footer Area to Footer.

In Footer develop it according to schema/design in attachment.
Customizer-Footer.zip

Currently, Author Name is way too bold in comparison to design. We need to reduce it to 500 to fit design.

Script should be wp_register_script before wp_enque_script. Same with a css files

Need to check all spaces between elements in design.

Like this example:

There's inconsistency with urls order. In Customizer they in one order and outputted in another order.

Note: Not a big deal, but it may confuse users.

Hover effects should have smooth animation, same speed as a transition on links (border-bottom).

• Button hover ("Read more" in post archive page)
• Icons in posts meta
• Links in paginotor
• And other places. Pretty much everywhere where visual effect is changed (hover) smooth animation should be applied

Change order and naming of Customizer Sections:

1. Site Identity
2. Menus
3. Theme Options (Combine Overall Site and Content Are - see separate issue for this one)
4. Header
5. Content
6. Footer
7. Fonts & Style (Combine all fonts into one - see separate issue for this one)
8. Widgets
9. Static Front Page
   Customizer-General.zip

Divide H1 - H6 into sections so it is possible to manage them separately
Move button options out of Body as they can be managed separately.

See design/schema for detailed information. You will need to divide few attributes and add few more.

Customizer-Fonts-Style.zip

If post is divided into multiple pages it is impossible to navigate to the next page
https://codex.wordpress.org/Function_Reference/get_the_posts_pagination

in PSD 22px, in theme 18px

"Read more", "Post Comment" blue button should have background color "Active color" (from customizer.

Let's set social icon color by default regular color and upon hover it becomes active color. As for example I have active color yellow, but transparent yellow looks really bad on blue background. See image:

According to design/schema.
Customizer-Header.zip

In tag for custom logo title attribute which should be equal to the value entered in customizer (Site Title).

Just one icon should be visible

visual-composer-starter/js/
and inc/customizer/js/

Combine Overall Site and Content Area into one - Theme Options

See design with exact fields, orders and titles.
Customizer-Theme-Options.zip

Default active color: #557cbf

From @AngeIII:

\VC_Fonts::vc_theme_google_font_variants looks wrong. Why it is hardcoded? if user selected 100 why not to add it?
// Only add "700" if it exists
if ( in_array( '700', $variants ) ) {
$chosen_variants[] = '700';
}

From @AngeIII:

VC_Image_Select_Control::enqueue
ng-image-select-control -> vct-ng-image-select-control
ng-image-select

Please check all scripts

The same problem as for author name.

Also please check other places where similar issue can be spotted.

Icons should be lower in order

Please take another look into the comments design. From the first look, many things are missing.

• .comments-area .comment-list .comment-author { font-weight: 700 }
  according to design should be regular weight
• font-weight
• padding left/right on the "Post Comment" button (in psd 40px, template 30px)
• Comment author name with link should be the same color as with no link
• ...

In Customizer we need to have demo import option that will import all the images and texts as presented within the design.

This will allow users to get started easy and see a real layout.

Note: We can/should discuss it in details in Slack

Customizer-General.zip

I added featured image to the post and activated Featured Image in Customizer. In post view I see featured image, then I disable feature image in Customizer, but image on top of the content is still there and not gone.

There are images in image folder of the theme design which we do not use (no option to import dummy data). So there is no reason to keep these images there.

Now there are 2 png images dark and white for close button, we need to replace them with one SVG which get color applied to it. Otherwise retina display will not be happy about some png images and we will have problems later on if we want to introduce more sandwich menu options/colors.

I have attached svg file to use - the size should be ok, just let me know.
close-icon.zip

For some reason Widget titles in footer are using active color, yet they are not clickable. See image:

When I select a number of columns for Footer widget and go to Widgets are I still don't see column option. I need to refresh Customizer by Shift+Cmd+R to see the changes.

For regular end-user, it will look like a clear bug.

Look into my settings, for some reason, I don't see background color for my header:

In Customizer if it is not native. If it comes from WP 4.7 - leave as it is.

Space between copyright text and submenu must be bigger, please review design for proper spaces.

Proudly povered ... must start in new line (see design)