vircomopensource / dbautofill Goto Github PK

Right now the documentation is really minimal (close to non-existent) and unclear.
The objective if to create a clearer and simpler documentation. If time permits, adding some peculiar case would be good, too.

• Readme
  • Features
  • Sample
• Wiki
  • Introduction (sample program)
  • Helpers doc
  • Basic types docs
  • Adding features doc

While testing for issue #3 Proposal, I discovered a little bug where plain field members do raise an exception in the AddParameterFromAttribute (L.302 of DbAutoFillHelper.cs).

Issue comes from the assertion that we're awaiting a property (model.GetType().GetProperty(propertyName).GetValu(model, null)).

The solution is to test like the following;

Type modelType = model.GetType(); 
PropertyInfo prop = modelType.GetProperty(propertyName); 
if(prop != null) { parameterValue = prop.GetValue(model, null); } 
else
{
    FieldInfo field = modelType.GetField(propertyName); 
    parameterValue = field.GetValue(model); 
}

Of course, the above example is an approximation of what's required.

Problematic Case

Consider the case where you have a stored procedure as follows:
DeleteGroup(AdminUserId, GroupId)

In this peculiar case, we do not have a structure like the following:

class GroupAdmin
{
public int AdminUserId; 
public int GroupId; 
}

Indeed, we consider creating an object for this quite useless... ?

Solution 1

The proposal would be to add an overload to the method :
ExecuteDbProcedureNameAsCallerName(params[] objects...)

Indeed, it would take a variable count of objects (tagged with DbAutoFillAttribute).
It would merge the members.

Possible Issue: Duplicate Members

To avoid this kind of error, allow only DbAnonymousValue instead of complex classes. This forces no-collision.

Or alternatively, allow complex types to merge, but throw exception on duplicate members -> this will throw an exception

Or, just silently override.

Sample

DbAnonymousValue<int> groupId = new DbAnonymousValue<int>("groupId", 2);
DbAnonymousValue<int> adminId = new DbAnonymousValue<int>("adminId", 45);
commandHelper.ExecuteDbProcedureNameAsCallerName(groupId, adminId);

Solution 2

The other proposal would be to add a type DbParameterUnion where objects are added to it but get treated differently than asimple list (flatten the list instead of acting like a structured type).

Possible Issue: Special Treatment

Indeed, I think it would force a special type treatment within the library and therefore is a bigger modification to the core, instead of just a layer of the library.

Sample

DbParameterUnion pu = new DbParameterUnion({"groupId", 2}, {"adminId", 45}); 
commandHelper.ExecuteDbProcedureNameAsCallerName(pu);

Workaround:

Right now, we creates wrapper. It's ugly, but it works...