vigour-io / is-number-like Goto Github PK

View Code? Open in Web Editor NEW

4.0 10.0 6.0 213 KB

Checks whether provided parameter looks like a number

License: ISC License

JavaScript 100.00%

is-number-like's Introduction

is-number-like

var looksLikeNumber = isNumberLike(val)

Checks whether provided parameter looks like a number

val (any) - the value to check
returns (boolean) looksLikeNumber - true if val looks like a number, false otherwise

const isNumberLike = require('is-number-like')
isNumberLike('2') // true
isNumberLike('a') // false

is-number-like's People

Contributors

Stargazers

Watchers

Forkers

laggingreflex marioagarcia sirlancelot ismisepaul jimdebeer breadchris

is-number-like's Issues

Vulnerable to NODE-SECURITY-606

is-number-like/yarn.lock

Line 2307 in 8a100d8

version "1.13.1"

Update to 1.14.1 to mitigate against NODE-SECURITY-606

Versions of sshpk before 1.14.1 are vulnerable to regular expression denial of service when parsing crafted invalid public keys.

function.length >0 breaks it

It breaks when val is a function and it has a length property >0 (TIL functions have a length property)

  const length = val.length
  if (!length) {
    return isNumber(val)
  }

remove lodash dependency

adds lots of kbs, not very fast either

`const isNumber = require('lodash.isfinite')` breaking CI

In circle CI, I'm getting this error on deploying. I can find similar errors all over the results, thinking CI doesn't like ES6.

I don't know may be we need a Circle CI config file? like: https://github.com/ipfs/js-ipfs-api/blob/db5d73156f900a97a9f1323b5cfefd0f4fa49d45/circle.yml

gulp ci-test-sequence

/home/ubuntu/uq-tw-sp-app/node_modules/browser-sync/node_modules/portscanner/node_modules/is-number-like/lib/index.js:2
const isNumber = require('lodash.isfinite')
^^^^^
SyntaxError: Use of const in strict mode.
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/ubuntu/uq-tw-sp-app/node_modules/browser-sync/node_modules/portscanner/lib/portscanner.js:4:20)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
npm ERR! Test failed.  See above for more details.

npm test returned exit code 1](url)gulp ci-test-sequence


/home/ubuntu/uq-tw-sp-app/node_modules/browser-sync/node_modules/portscanner/node_modules/is-number-like/lib/index.js:2
const isNumber = require('lodash.isfinite')
^^^^^
SyntaxError: Use of const in strict mode.
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/ubuntu/uq-tw-sp-app/node_modules/browser-sync/node_modules/portscanner/lib/portscanner.js:4:20)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
npm ERR! Test failed.  See above for more details.

npm test returned exit code 1

Incorrect return value for e.g. `3e1.2`

Returns true, but coercing this to a number produces NaN

is-number-like versioning problem for nodejs not supporting ES6

Hi,

I believe the version should be bumped to v2 allowing the tools using the older version of node to still work as expected.

You can currently get a lot of build errors from system not able to upgrade node and relying to this package.

'const length = val.length' breaking build

Just like the other issue with const, this const usage is breaking the build.

Move or remove bubleify dependency

bubleify is listed in the production dependencies of this module. This seems to be causing unnecessary bloat when this module is depended upon by other packages.

At the very least, it should be moved to devDependencies but after looking a little deeper, this module doesn't appear to even use bubleify! Let's just remove it for now.

SyntaxError: Use of const in strict mode.

Using const isNumber = require('lodash.isfinite') in combination with 'use strict' in index.js breaks compatibility with Node.js v0.12.

My build fails because of that:

/home/travis/build/caiogondim/logdown.js/node_modules/browser-sync/node_modules/portscanner/node_modules/is-number-like/lib/index.js:2
const isNumber = require('lodash.isfinite')
^^^^^
SyntaxError: Use of const in strict mode.
at exports.runInThisContext (vm.js:73:16)
at Module._compile (module.js:443:25)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/home/travis/build/caiogondim/logdown.js/node_modules/browser-sync/node_modules/portscanner/lib/portscanner.js:4:20)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)

Log: https://travis-ci.org/caiogondim/logdown.js/jobs/183316473

The result is that our logger module logdown.js is not compatible with Node.js v0.12 and below anymore. 😢