vicpenap / prettykit Goto Github PK

I have a added PrettyKit in a static library that I use for several different projects of mine but it is giving lots of build errors when compiled.

Xcode 6, iOS 8, using PrettyTableViewCell and the app is crashing related to KVO on line 481 -
any idea?

- (void) observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context 
{
    if ([keyPath isEqualToString:@"frame"]) 
    {        
        UIView *contentView = (UIView *) object;
        CGRect originalFrame = contentView.frame;

        float shadowMargin = [self shadowMargin];

        float y = contentView_margin;
        switch (self.position) {
            case PrettyTableViewCellPositionTop:
            case PrettyTableViewCellPositionAlone:
                y += shadowMargin;
                break;
            default:
                break;
        }
        float diffY = y - originalFrame.origin.y;

        if (diffY != 0)
        {
            CGRect rect = CGRectMake(originalFrame.origin.x+shadowMargin,
                                     originalFrame.origin.y+diffY,
                                     originalFrame.size.width - shadowMargin*2,
                                     originalFrame.size.height- contentView_margin*2 - [PrettyTableViewCell neededHeightForPosition:self.position tableStyle:_tableViewStyle]);
            contentView.frame = rect; // --> crash here!
        }
    }
}

I think the example lacks the use of a PrettyCustomViewTableViewCell.

Specifically, I have a project where I use this class, and I haven't quite understood how to use it correctly. My cells contents aren't properly masked (the view goes out of the boundaries when there are rounded corners) and I haven't found a public property to set the view.

Could you enlighten me?

Is there a way to make transparent rounded corners?

The vertical shadow on the left of a grouped 'middle' PrettyTableViewCell is not consistent. It seems to be slightly rounded, as seen in this screenshot from the example app (with the background changed to white):

It is less noticeable on the right side:

This is pretty small but still noticeable.

I've got a custom PrettyKitTableViewCell subclass which I'm trying to get a dropshadow on (grouped table view) and when i set the dropsShadow property to YES in cellForRowAtIndexPath no shadow is created. I'm still relatively new to iOS, so i'm just wondering if anyone can suggest some things I should check that I may have missed?

This is an iOS 5 - 6 app btw, using the latest version for download from this repo.

Thanks

Thanks for the great library!!

I have one problem about memory management!

As title, when I use PrettyTableViewCell, it cannot be released.

I guess it's because of "[self.contentView addObserver:self forKeyPath:@"frame" options:NSKeyValueObservingOptionOld context:nil];"
The "[self.contentView removeObserver:self forKeyPath:@"frame"];" is in "dealloc" method, but without removing the cell cannot be dealloc.

Not sure if I was right.

Please check this.

Thanks a lot.

I can't make PrettyTabBar translucent. Even using iOS 5 appearance method witch works with UITabBar.

Is there a way to add shadow to the PrettyToolBar?

I didn't understand how do I use the navigation bar, I'm not using any xib files, so how do I change my navigation bar to be PrettyNavigationBar?

I need to know how to set the PrettyNavigationBar using a Navigation Controller in storyboard?
Im dead stuck and i neeeed help!

PrettyKit is very nice library, but It doesn't work at searchDisplayController.searchResultsTableView.

static NSString *CellIdentifier = @"Cell";
PrettyTableViewCell *ccell = (PrettyTableViewCell *)[self.searchDisplayController.searchResultsTableView dequeueReusableCellWithIdentifier:CellIdentifier];
if (ccell == nil) {
  ccell = [[[PrettyTableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier] autorelease];
  ccell.tableViewBackgroundColor = self.searchDisplayController.searchResultsTableView.backgroundColor; 
  ccell.textLabel.font = [UIFont fontWithName:@"Palatino-Roman" size:14];
}

[ccell prepareForTableView:self.searchDisplayController.searchResultsTableView indexPath:indexPath];
ccell.textLabel.text = @"test";   
if (indexPath.section == 0) {
  ccell.cornerRadius = 20;
}
else {
  ccell.cornerRadius = 10;
}

Any ideas? Thanks for your help.

The custom selection gradient effects and everything do not work when I extend my custom cells from PrettyTableViewCell and use xibs. Any ideas?

very pretty, thanks for the great job.

I wish to display detailLabel in prettytableviewcell, but the background of the detaillabel text was cleared so the background of the tableview is displayed. How can I solve the problem? thank you.

So if you start with 1 row and insert a new row in a grouped table, the first row will have rounded corners on top, but the now second row still has the 4 rounded corners.

Similar issue when you delete the first row of a grouped table.

To fix, I guess I could reload the affected rows (in my tableviewcontroller) every time an insert/delete is done... but I wonder if there's a way PrettyTableViewCell can handle it automatically?

This must be a dumb question but how can I access contentView of PrettyGridTableViewCell?

Hil
The library is very nice , Will it have an arc version soon ???

Hi everyone,

I try to change the selectedIndex by default by [cell.selectedIndex or cell setSelectedIndex:1]

Both ways doesn't work. Has anyone a solution for this problem?

Best regards

Tim

Setting a table and the cells background colors to transparent shows some ugly separators in between the cells. For some reason there is space between each cell, and a UIView in between each with a pixel height of 1.

Hi

I'm having trouble getting animations to work with PrettyKit cells.

I want to animate the cells height when a user taps the cell.

When a user selects the cell i call

[tableView beginUpdates];
[tableView endUpdates];

And returns a different height in tableView:heightForRowAtIndexPath. This makes the cell animate to its new height.

All this works like a charm, but I'm having trouble with the resizing of the backgroundView. Currently the backgroundViews content stretches while the cell animates. This is not what i want and it looks horrible. I want the backgroundView to redraw its content during the animation. Is this possible, and if so, how?

I've illustrated the problem in the following image (don't mind the arrow in the cell, its my custom implementation. Same behaviour with unmodified PrettyKit cells).

.

Update:
I found out that this is what happens:

1. The cell starts out as a big cell. Everything looks good and everyone is happy.
2. The user clicks the cell.
3. The backgroundView redraws for its new height.
4. The cell animates and gets smaller. And therefore the background view is in a stretched state during the animation.

Hi, I got this error when implementing PrettyTableViewCell to both MainViewController and DetailViewController in a navigation stack.

Just a heads up, I'm not sure if this is a bug in XCode or what, but the newest NDAd XCode (DP3) is generating an error on line 99 that NSIndexPath *_indexPath; is a duplicate member, probably all the way back to UITableViewCell itself. Most likely a private property. I had to edit the .h and .m files and turned it into _indexPat, seems to have fixed it.

You'll have to keep watch for the next couple of preview releases to see if this continues

Hi, looks like your awesome toolkit does not work out of the box with UIStoryboard created cells (and I doubt it will work with NIBs anyway because of missing awakeFromNIB). Therefore I wrote a little workaround that seems to fix the problem:

- (void)configureCell {
    if(_configured) {
        return;
    }
    _configured = YES;

    [self.contentView addObserver:self forKeyPath:@"frame" options:NSKeyValueObservingOptionOld context:nil];


    PrettyTableViewCellBackground *bg = [[PrettyTableViewCellBackground alloc] initWithFrame:self.frame 
                                                                                    behavior:CellBackgroundBehaviorNormal];
    bg.cell = self;
    self.backgroundView = bg;
    [bg release];

    bg = [[PrettyTableViewCellBackground alloc] initWithFrame:self.frame
                                                     behavior:CellBackgroundBehaviorSelected];
    bg.cell = self;
    self.selectedBackgroundView = bg;
    [bg release];

    [self initializeVars];
}

- (id)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reuseIdentifier
{
    self = [super initWithStyle:style reuseIdentifier:reuseIdentifier];
    if (self) {
        [self configureCell];        
    }
    return self;
}

I added the call here too:

- (void) prepareForTableView:(UITableView *)tableView indexPath:(NSIndexPath *)indexPath 
{
    [self configureCell];
    _tableViewStyle = tableView.style;
    self.position = [PrettyTableViewCell positionForTableView:tableView indexPath:indexPath];
}

Hope this is somehow usefull.

Cheers,
Dirk

If you observe closely the place where the separator is drawn the shadow is broken. This happens even if the separator is not drawn. I am assuming this is some kind of margin between cells being drawn and its shadow path

Hello everyone,

I use PrettyKit in one of my apps at the App Store. I have 500 active users and the app crash by some people (iPad 2, 3, 4 / iOS 5.1.1 - iOS 6.1.3).

0x00082903 -PrettyTableViewCellBackground drawRect:

Has everyone else the problem? I can't simulate the problem on my test devices.

Hi,

Can you tell me the cell selection in PrettyGridTableViewCell. I need to navigate the page to another page when i click the 1st cell of the PrettyGridTableViewCell. I searched the method but i did find that one. waiting for the reply

Thanks in Advance.

With Regards,

S.SriBharanidharan

Is there any way to have a pretty uitableview on iPad? The corners are squared on iPad Uitableview regardless of the corner radius.

Thanks in advance.

If you set cornerRadius to 0 and tried drawing a border around the cell, the top-left corner has a single-pixel not drawn.

I was trying to get the library working with EZForms which uses interface builder static cells in their examples to create forms with TableViews.

I could not get pretty kit to work this way so i made the following cateogry and setup the view in -willDisplayCell

https://gist.github.com/j-mcnally/5079016

Hi vicpenap,
I actually planned to send you a private message but I did not find any way to do this so Im writing this post.

I am starting a new iOS application and I think PrettyKit is what i need for my application. My application requires animated insertion and deletion operations but PrettyKit is not support those operation as I see. I would love to make required enchantment on PrettyKit but my enchantments are changing usage of the PrettyKit a little bit.

Usage Changes;
1- User of this library will not need to call "prepareForTableView: indexPath:" method of PrettyTableViewCell under "tableView:cellForRowAtIndexPath:" method of UITableViewDelegate.
2- User needs to use a class named PrettyTableView instead UITableView

Enchantments;
1- PrettyKit will support adding and deleting cells with animation. (Corners of cells will animate like native UITableViewCell class).
2- PrettyCells can be designed in interfaceBuilder. (Their appearance will not be able to edited in interfaceBuilder but their content will be).

If you are okay with these changes I will upload my changes with their documentation soon.

The default height of a grouped PrettyKitTableViewCell is 44 while I believe the default height in the SDK is 50.

I wanted to send this in a private message, but couldn't find how.. anyway, I'm just confused on this one thing. (and please bear with me because I'm rather new to coding)

In my app I have a tab bar and three views. I can implement the PrettyNavigationBar using interface builder in two out of the three views. The tableview is the one I am having trouble with. Is there a way i can implement a Prettynavbar inside a tableview using interface builder? -- I just can't figure out how..

This is not an issue but can you add a new cell that has a textfield with a label. I made a custom cell with the norma UITableView but i would like to use your code. I can't add the label + Textfield in your cell. I've tried a few thing.

ps. I don't care for the performance issue.

Thanks,

ThaAppleWizz