vicentllongo / simplecov-json Goto Github PK

Some companies will only use gems with a certain license.
The canonical and easy way to check is via the gemspec,

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Even for projects that already specify a license, including a license in your gemspec is a good practice, since it is easily
discoverable there without having to check the readme or for a license file.

For example, there is a License Finder gem to help companies ensure all gems they use
meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough
issue that even Bundler now generates gems with a default 'MIT' license.

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file),
github has created a license picker tool.

In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally
looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :).

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue and let me know. In either case, I'll follow up. Thanks!

p.s. I've written a blog post about this project

/usr/local/bundle/gems/simplecov-json-0.2/lib/simplecov-json.rb:16:in `block in format': undefined method `coverage' for #<SimpleCov::SourceFile:0x000056089302af48> (NoMethodError)
Did you mean?  coverage_data
	from /usr/local/lib/ruby/2.6.0/forwardable.rb:230:in `each'
	from /usr/local/lib/ruby/2.6.0/forwardable.rb:230:in `each'
	from /usr/local/bundle/gems/simplecov-json-0.2/lib/simplecov-json.rb:11:in `format'
	from /usr/local/bundle/gems/simplecov-0.18.2/lib/simplecov/result.rb:49:in `format!'
	from /usr/local/bundle/gems/simplecov-0.18.2/lib/simplecov/configuration.rb:196:in `block in at_exit'
	from /usr/local/bundle/gems/simplecov-0.18.2/lib/simplecov.rb:201:in `run_exit_tasks!'
	from /usr/local/bundle/gems/simplecov-0.18.2/lib/simplecov/defaults.rb:31:in `block in <top (required)>'

Can you please fix it. I think it is related to a pull request that is already submitted. Can you please release the gem with the fix?
Sonarqube expects this output, it is not accepting the simplecov's default .resultset.json output.

Tests are broken, because attribute coverage needs to be updated to coverage_data. Related PR #12

I don't really use this gem myself anymore so I can't properly maintain it. Asking here if someone is interested to take the ownership of the GitHub repo and the gem.

PR #12 is a breaking change. It no longer works for older versions of simplecov.

Formatter SimpleCov::Formatter::JSONFormatter failed with NoMethodError: undefined method `coverage_data' for #<SimpleCov::SourceFile:0x00007f8022ed7868>
Did you mean?  coverage (/Users/kevjin/.rvm/gems/ruby-2.6.4/gems/simplecov-json-0.2.1/lib/simplecov-json.rb:16:in `block in format')

Ideally, we should support both attributes coverage_data and coverage.

I will make a PR for this fix :)

.rvm/gems/ruby-2.0.0-p247/gems/simplecov-json-0.2/lib/simplecov-json.rb:17:in block in format': undefined methodnan?' for 0:Fixnum (NoMethodError)