vhs / api Goto Github PK

Queries that should return a 404 or similar error return a 200 OK with the body text containing the response code. They should actually be providing a 404 response and I-don't-really-care-what for a body.

Example:
http://api.vanhack.ca/s/vhs/data/invalidname
http://api.vanhack.ca/s/vhs/data/invalidname.json
http://api.vanhack.ca/s/vhs/data/invalidname.txt

http://api.hackspace.ca needs to be migrated to the Talk server, which uses docker to manage its web services. We'll need to create a docker image of VHSAPI, deploy it to the Talk server, test it, and then reconfigure DNS entries for api.hackspace.ca and isvhsopen.com.

Important setup files:
README.md - install notes
INSTALL.sh - moves the config scritps below
etc/service/vhsapi/run - starts perl service
etc/nginx/vhs-api - nginx config

Here is a start to a Dockerfile:

FROM ubuntu         #Not sure what the Talk server is running

RUN apt-get update && apt-get install libexpat1-dev libssl-dev daemontools daemontools-run
#Do we need to apt-get carton as well?
RUN carton install

EXPOSE 3000        #VHSAPI listens on this port
CMD ["api/etc/service/vhsapi/run"]

api/src/datapoint.js

The following two function names, along with their comments, imply that the functions do more validation than they actually do. I don't know where these functions are used, so I'm not sure if it's the names and comments that are wrong, or if the body of the functions needs fixing. @interlock?

49:
// validate the space and datapoint name
_validateSpaceName: function(space, name) {

56:
// validate the space and datapoint name, value pair
_validateSpaceNameValue: function(space, name, value) {

It's taking up to 5 seconds for a value update to change the value received upon a query. I don't know enough about this framework to know if this is expected.

To Reproduce:
Prepare two web browser tabs.

1. Update tab: http://api.hackspace.ca/s/vhs/data/test1/update?value=test1
2. Query tab: http://api.hackspace.ca/s/vhs/data/test1.txt

Go to Query tab, and make sure the value is different from the value being submitted in the Update's querystring.
Submit Update query, i.e. go to Update URL.
Immediately switch to Query tab, press F5 repeatedly and watch for change.

Current Behaviour:
The value seems to change within 5 seconds of submitting an update.

Expected Behaviour:
The first query after an update, no matter how soon after, should return the updated value.

@interlock, do you have any idea why this is happening?

Run and commit the vendored tars that carton bundle generates so a carton install --cached completes faster.

Making docker builds much faster.