vhochstein / render_component Goto Github PK

it looks like this fork has the most recent version of this gem.. supporting rails 3.0
quickly, I could not find a more active one... but let me know if you think I am wrong...

I am actually in the progress of porting an rails 1.1.6 application to rails 4.1.4
which is using components extensively... is there a better solution nowadays? or should I attempt to create yet another fork of this attempting to make it work with 4.1 ?

thanks

can you fix this issue to support rails 3.1 rc4?

Bundler could not find compatible versions for gem "railties":
In Gemfile:
render_component_vho depends on
railties (~> 3.1.0)

rails (= 3.1.0.rc4) depends on
  railties (3.1.0.rc4)

If render_component is used alongside with devise (or warden) it can lead to no method error "authenticate!" for nil:NilClass.
This is due that the rendered controller will try to enforce authentication looking into the request.env['warden'] object to call authenticate! on it.

To fix this particular case we need to add on line 121 of

# render_component/lib/components.rb +121
request_env["warden"] = request.env['warden'] if request.env['warden']

I think that for a more broad compatibilty, more variables from the request.env should be copied.

When my controller returns 304 result, the render_component fails with this error:

undefined method `redirect_url' for []:Array

on this line:

response = component_response(options, true)[2]

** if response.redirect_url **
  redirect_to response.redirect_url
else
  render :text => response.body, :status => response.status
end

The reason is because controller.dispatch(action, request) returns an array with:

[304, {"ETag"=>"....", "Cache-Control"=>"max-age=0, private, must-revalidate"}, []]

instead of the 200 result which looks like:

[200, {"Content-Type"=>"text/html; charset=utf-8", "ETag"=>"\"...\"", "Cache-Control"=>"max-age=0, private, must-revalidate }, #<ActionDispatch::Response:0x007f8eee1918b8 @writer=...

Tried to add request_env["Cache-Control"] = "no-store, no-cache, must-revalidate" as a header but no luck.