vfalies / tmdb Goto Github PK

I'm working on adding PHP 7.4 and PHP 8 support.

The only change needed for PHP 7.4 was upgrading PHPUnit and refactoring some tests to avoid the use of deprecated PHPUnit features.

For PHP 8 support we will need to refactor some of the wrapper code itself.

Are there any PHP versions that we can drop support for? PHP 7.1 has been EOL for over a year and PHP 7.2 for nearly 6 months. PHPUnit 7 doesn't support PHP > 7.3 and is also EOL.

I think dropping support for those two PHP versions would greatly benefit us and simplify the process of adding support for newer PHP versions. What are your thoughts?

TMdb recently implemented Cloudfront in front of the API, and is refusing GET requests that contain a post body.

In Tmdb.php line 177:

json_decode() expects parameter 1 to be string, object given

I can add use the following code to get TMdb to return videos to me, but I have no way to access them using the Items\Movie class.

$item->getMovie($movie['id'], ['append_to_response' => 'videos'])

Is there any way to get the cast of a tv show?

https://developers.themoviedb.org/3/find/find-by-id

How can I use this API?

It seems there's not enough documentation on how to fetch media? I see poster_path inside the array of $movies->current() and the example has media helper set like this:

$media = new Media($tmdb);
$url = $media->getPosterUrl('/AbJBXaVPrdXROwb8KmgWUPU2XJX.jpg');

What is that jpg supposed to be in the documentation? How should I combine the find based on IMDb and this "media helper"? How to get poster or backdrop URL?

Sorry that I'm not familiar of this types of wrappers. $movies->current()->getTitle() and things like that are easy here but fetching media is a mystery here.

I'd like to discuss and hear your ideas for how to best implement the changes endpoint for specific items.

• It seems that the response for changes on a tv show/movie/person follow a mostly-standard format, but each different item will have certain differences in its potential values. That makes me think that a generic ItemChange object is not the way to go.
• How many levels deep do we want to go with this? For instance for TV show changes sometimes it will return that a TV season or episode has been changed. Do we want to then fetch and parse those changes automatically or should that be up to the developer to fetch themselves?
• Do we want to provide a full interface for each type of change? Something like getPosterChanges() that returns either a change or null, or do we just return an array of changes consisting of "poster" => "newValue"?

I would love to hear your thoughts and ideas on this before beginning to implement it.

Great work on the foundations of this API wrapper. Would you accept pull requests to flush out the missing API endpoints?

Also, how would you like to see the Daily File Exports implemented? Since there's no authentication required for them and they're returned as gzipped non-standard json (json objects separated by newlines) they'd need their own parsing.

  Problem 1
    - vfalies/tmdb[1.8.2.x-dev, ..., 1.8.3] require guzzlehttp/guzzle ~6.3 -> found guzzlehttp/guzzle[6.3.0, ..., 6.5.x-dev] but it confl
icts with your root composer.json require (^7.0.1).
    - vfalies/tmdb[1.8, ..., 1.8.1] require guzzlehttp/guzzle 6.3.3 -> found guzzlehttp/guzzle[6.3.3] but it conflicts with your root com
poser.json require (^7.0.1).
    - vfalies/tmdb 1.8.2 requires guzzlehttp/guzzle ~6.3.3 -> found guzzlehttp/guzzle[6.3.3] but it conflicts with your root composer.jso
n require (^7.0.1).
    - Root composer.json requires vfalies/tmdb ^1.8 -> satisfiable by vfalies/tmdb[1.8, ..., 1.8.3].

My composer.json:

    "require": {
        "php": "^7.3",
        "fideloper/proxy": "^4.2",
        "fruitcake/laravel-cors": "^2.0",
        "guzzlehttp/guzzle": "^7.0.1",
        "laravel/framework": "^8.0",
        "laravel/tinker": "^2.0"
    },

Using the following code, I'm unable to retrieve results from TMdb.

$movie = [];
$tmdbMovieData = [];
$item = new Item($this->tmdb);
$tmdbMovieData 	= $item->getMovie(11);
$movie['cast'] = $tmdbMovieData->getCast();
$movie['crew'] = $tmdbMovieData->getCrew();
$movie['trailers'] = $tmdbMovieData->getVideos();
var_dump($movie);

If I look at the constructor for Items\MovieVideos, I can see results being returned if I run
var_dump($this->data->results);

This is related to #37. I'm not sure if I'm doing something incorrectly, or if there are a problem with these methods.

Hi. I'm trying to use
` `` foreach ($infos->getBackdrops() as $backdrops) {

				var_dump($backdrops); 	
	 
				 }```

for
$item = new Item($tmdb); $infos = $item->getMovie(35031, array('language' => 'en-EN'));
but it shows blank. Any help?