Small file uploads are not handled properly by Apex about vertx-web HOT 5 CLOSED

Just as an FYI, writing an equivalent test in vert.x raw http handling (rather than wrapped by Apex) behaves properly, so the problem lies within Apex somewhere.

from vertx-web.

This looks like a race condition to me. Did a little bit of debugging, and it's clear that with both a small and large file attachment, HttpServerRequestImpl::streamToFileSystem is called. This method pauses the request and then resumes it once the Pump to file has been set up.

For a small file, however, the resume call happens AFTER HttpServerFileUpload::complete() is called, meaning that at the point the latter method is called, the request is still paused. For a larger file, HttpServerFileUpload::complete() is called before the resume call within HttpServerRequestImpl::streamToFileSystem, so in effect a small file upload is identified as complete before the request is resumed. This then falls foul of the "paused" check in HttpServerFileUpload::complete() and the notifyEndHandler() call is not made, meaning that the request does not complete on the server. In short this actually appears to be a vert.x bug rather than an Apex bug.

from vertx-web.

Thanks for looking into this.

I'll take a look probably tomorrow, if you can create a reproducer only using Vert.x (not Apex) even better :)

from vertx-web.

Thanks Tim, I'll try and carve out some time today to create a vert.x only reproducer, can't promise it though as I'm a bit stuck for time till Thurs now (from my point of view there's no urgent need for this to be fixed, so unless you're pressed by others, please feel free to hold off till I've at least attempted a vert.x only reproducer).

from vertx-web.

This should be fixed now (bug in vertx-core). I've also added some more tests.

from vertx-web.