Handling close connection with GraphQLWSHandler about vertx-web HOT 8 OPEN

@aleksandar78 looks like an omission to me. Would you like to contribute the enhancement?

from vertx-web.

@tsegismont I found a way to pass the handler when the close socket event is called.
Inside connectionInitHandler where init Message is passed as the argument for the first time, the WebSocket instance can be used for the same purpose as endHandler in the ApolloWSHandler.

This is the trick that works well but it's not clear on the GraphQLWSHandler API level, IMO. The solution could be exposing endHandler or adding an example in official documentation to explain how to handle this kind of situation.

What do you think?

Anyway, I'm available to help.

from vertx-web.

Can you paste a snippet to better understand your workaround?

from vertx-web.

This is kotlin pseudo-code passed to GraphQLWSHandler.connectionInitHandler

fun onInit(event: ConnectionInitEvent) {
    val socket = event.message().socket()

    // validate token sent by graphql client
    validateToken(event.message())
      .compose { username ->
          fetchUser(username)
      }
      .onSuccess { user -> 
        val textHandlerID = socket.textHandlerID()
        sessionMap[textHandlerID] = user
        socket.closeHandler {
          sessionMap.remove(textHandlerID)
        }
        event.complete()
      }
      .onFailure { ex ->
        val error = createAuthException(ex, socket)
        event.fail(error)
      }
  }

from vertx-web.

This is kotlin pseudo-code passed to GraphQLWSHandler.connectionInitHandler

Thank you @aleksandar78

The problem with this code is that the WebSocket can have only one closeHandler, which means this will not be invoked:

So, having an endHandler to set in io.vertx.ext.web.handler.graphql.ws.GraphQLWSHandler and invoking it in io.vertx.ext.web.handler.graphql.impl.ws.ConnectionHandler#close seems like the right thing to do

from vertx-web.

@tsegismont can you point to me vert.x contributor's guide (if any) before I make the pull request?
I can make the effort but I'm not familiar with your branching strategy.

Thanks

from vertx-web.

https://github.com/eclipse-vertx/vert.x/blob/master/CONTRIBUTING.md

First, you need to make a pull request to master branch (which is where Vert.x 5 development happens now). Then you can backport to the 4.x branch (by creating another pull request).

from vertx-web.