Giter Club home page Giter Club logo

mediasoup-website's People

Contributors

copiltembel avatar ethand91 avatar fippo avatar ggoldens avatar grootgordon avatar ibc avatar j1elo avatar jbaudanza avatar jmillan avatar juandebravo avatar ksj14-kumar avatar leaysgur avatar mstyura avatar nazar-pc avatar nekonako avatar pratikdaigavane avatar ragedpanda avatar scaret avatar snnz avatar spccman avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

mediasoup-website's Issues

Device `close` event doesn't exists

As shown at https://mediasoup.discourse.group/t/are-close-events-in-mediasoup-client-replicated-from-server-side/3881/5?u=piranna and https://mediasoup.discourse.group/t/are-close-events-in-mediasoup-client-replicated-from-server-side/3881/8?u=piranna, mediasoup-client Device shows a close event that doesn't exist in the actual implementation, the same that there's no close() method at all to be called. Based on the anchor of the URL, seems like it was copy&pasted from Mediasoup documentation, this needs to be removed.

Is the description of room.getPeerByName(name) in the API document misleading?

In the explanation as below

room.getPeerByName(name)

Retrieves the Peer with the given name, or undefined if not found.

the above description seems confusing to me. I expect that I'll get undefined if the room doesn't have the peer in the argument. However getPeerByName returns newly created mediasoup Peer as long as I tested. So I think the description is misleading.

Disabling rtp orientation header extension for mobile Safari

Hi,

We implemented a workaround for orientation issues when sending video from iOS, and thought we’d post it here in case it’s useful to others.

We support Firefox, and we record video tracks using PlainRtpTransport/ffmpeg. For both of these use cases, video received from iOS clients is not properly rotated. Firefox does not support the video-orientation rtp header extension. And ffmpeg doesn’t either (or, perhaps, we have failed to figure out how to pass the orientation signaling through to ffmpeg in a usable fashion.)

So, removing the urn:3gpp:video-orientation from the sdp generated by mediasoup is a good workaround for these orientation issues. (Removing the extension from the sdp forces the client to encode the video rotated, rather than signaling rotation out of band.)

Here’s how we disable the extension, prior to calling the mediasoup-client device.load() function:

  log('loading soup device', routerRtpCapabilities);
  // remove rtp header orientation extension for mobile Safari,
  // because neither Firefox nor ffmpeg support it. so we need
  // Safari to encode the video as rotated, rather than just
  // signal rotation changes
  if (getBrowserName() === 'Safari' && browserMobile_p()) {
    routerRtpCapabilities.headerExtensions =
      routerRtpCapabilities.headerExtensions.filter(
        (ext) => ext.uri !== 'urn:3gpp:video-orientation'
      );
  }
  await this.soupDevice.load({ routerRtpCapabilities });

In our tests, Android Chrome clients work fine, which suggests that Android Chrome is not actually using this header extension. (We plan to revisit this to test more heavily on Android, however, and will update this post if we learn anything new.)


Kwin

mediasoup.types properties not found

Hi, thank you for develope the mediasuop library.
First, i'm sorry for my engslish.

I have try mediasoup.types properties like in documentation.

on the documentation is like this :

import { Worker, RtpParameters } from "mediasoup/lib/types";

but i got path module not found.

i think the correct way is :

import { Worker, RtpParameters } from "mediasoup/node/lib/types";

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.