The android-vitosha-poker-odds from velbazhdsoftwarellc

android-vitosha-poker-odds's People

Contributors

Stargazers

Watchers

android-vitosha-poker-odds's Issues

There is a bug reported by Sybren Sijbrandij.

Hello Todor,

I spend some more time in finding the bug today together with my teacher, after some hours when we almost checked everything (everything we checked worked good) we found the bug.

The bug is in this code part:

public void calculatePlayersHandScore() {
        /*
         * Calculate hand score.
         */   

        for (int i = 0; i < game.numberOfPlayers; i++) {
                        Card[] hand = new Card[Constants.NUMBER_OF_EVALUATION_HAND_CARDS];

                        game.players[i].handScore = 0L;

                        for (int j = 0; j < Constants.NUMBER_OF_POSSIBLE_HANDS_FOR_EVALUATION; j++) {
                                long score = 0L;

                                formFiveCardsHand(hand, j, game.players[i], game.board);

                                sortWithoutLeadingAce(hand);
                                score = evaluateHand(hand);
                                if (score > game.players[i].handScore) {
                                        game.players[i].handScore = score;
                                }

                                sortWithLeadingAce(hand);
                                score = evaluateHand(hand);
                                if (score > game.players[i].handScore) {
                                        game.players[i].handScore = score;
                                }  

                        }
                }
    }

The bold line was in the second for loop in your version but we moved it outside the second for loop and inside the first loop. Otherwise the handscore is reset every loop. I also checked the initial C version, it seems the same fix will work there too, but to make sure you have to test that.

Regards,
Sybren

Recommend Projects