vanirdev / variantencumbrance Goto Github PK

Hello,

Can you add compatibility with the metric system for movement reduction by adding values in the settings, so we can define movement reduction ourselves?

Thx!

If I click the Install button in the Foundry module search box I get a red error popup.

Module Version: v0.6.7

Describe the bug
(Description made by a non native english speaker :) )
AE not working

After the update yesterday, I went into the parameters, and put some numbers. It was working for some time...
After several clicks on the character sheet, the active effect dissappeared (speed reduction)... And it's impossible to put it back.

I tried today too, on a PC who was "slightly encumbered", made his weight "ok" for no malus, and added him some stuff to make him encumbered again.............. nothing !

Thanks for your mod anyway.

Hello,

Seems movement reduction is not working anymore with the newest version of Tidy5e

Module Version: v0.7.3

Describe the bug
While using the PopOut! module, and with an item container open, I receive an error if I move an item from a popped out character sheet into the open item container.

To Reproduce
Steps to reproduce the behavior:

Pop out a character sheet
Add item to character sheet inventory
Open an item container
Move the item from the popped out character sheet to the open item container
See error

Expected behavior
No error should be produced.

Screenshots

Browser:
Chrome

Foundry Version:
0.9.245

Game System:
DnD5e - Fifth Edition System - 1.5.7

Additional context
Only following modules are installed:

Item Containers
libWrapper
socketlib
Variant Encumbrance+Midi
PopOut!

After enabling module and and applying changes.

FVTT 0.8.8
DND5e 1.4.2

When importing a character from the ddb-importer module, the character import hangs and the console show that it constantly triggers this console log:

for (const effectEntity of actorEntity.effects) {
    if (typeof effectEntity.getFlag('VariantEncumbrance', 'tier') === 'number') {
        if (!effectEntityPresent) {
            effectEntityPresent = effectEntity;
        } else {
            // Cannot have more than one effect tier present at any one time
            console.log("VariantEncumbrance | deleting duplicate effect", effectEntity);
            await effectEntity.delete();
        }
    }
}

Environment Details

• Foundry VTT Version: 0.8.9
• Operating System: Windows 10
• How Are You Using Foundry: Chrome
• Which Game System: dnd5e
• Modules Enabled?: yes [Inventory+, Item Containers, libWrapper, Variant Encumbrance]

Issue Description

Regardless of other modules installed, this module eliminates the weight of any carried currency.

When somebody get encumbered, status announce is repeatedly displayed.

I think this module keep creating that effect.

Fvtt v0.8.9(chrome)
window 10
dnd 5e v1.5.2
mod v0.5.19.

Hi its me again, sorry to bother you but, i cant find the option for "Atribute Waight" in the Effects section.

is it possible to add as i can see you have implemented support for it
if the correct effect is the "encumbrance" class then when i do Add -10 it spits back the Nan Value on waight and the same for + or multiply

For most of my actors, there are no issues but this particular actor is having massive constantly increasing negative numbers for all speeds anytime the actor's inventory is changed. The effects keep multiplying in that user and they cannot be deleted.

Export of the 5E actor: https://we.tl/t-Oqq6jmEfe6

When dragging an inventory item from one token to another (not from a compendium to a token) I get an error with the following message in the console:

Uncaught (in promise) Error: The key B3EbdfIsEwnQO4up does not exist in the EmbeddedCollection Collection
[No packages detected]
at Map.get (/G:/FoundryVTT/resources/app/common/utils/collection.mjs:106)
at ServerDatabaseBackend._updateEmbeddedDocuments (/G:/FoundryVTT/resources/app/dist/database/backend/server-backend.mjs:1)
at ServerDatabaseBackend.update (/G:/FoundryVTT/resources/app/common/abstract/backend.mjs:153)
at async Socket.handleEvent (/G:/FoundryVTT/resources/app/dist/server/sockets.mjs:1)

This bug goes away when I turn off Variant Encumbrance, or when I turn off Illandril's Inventory Sorter. I haven't always gotten this bug though, and he hasn't updated his in a few months so I suspect the issue is from this module.

I'm using Inventory + module for bag of holding(Ignore item weight) but activating this module makes the inventory counts the weight of items in the bag. 😢

My environment.
Fvtt v 8.9
Inventory + v0.3.6
Variant encumbrances+midi v0.5.1

Hi,

Just wanted to let you know if the sheet is changed to another one. It will no longer pick up weight changes.
Example click on or off weightless in backpacks.

Hi! Looking great so far!

Is there anyway to use further homebrew rules? For example the Inventory Slot system introduced in Darker Dungeons?

What happens if you don't use midi?

Module Version: v0.6.8

Describe the bug
It seems that this module combined with the newest version of Item Containers (1.8.9) "reverses" when the carrying weight of a bag is calculated. Without this module enabled, I can equip a bag from Item Containers, and the weight is then added and calculated, and when I unequip it, the weight is removed. With the module on, it seems to reverse this?

To Reproduce
Steps to reproduce the behavior:

1. Use the Backpack item from the DnD 5e compendium, have the aforementioned modules enabled.
2. Equip/unequip the bag, notice the weight added doesn't correlate right depending on whether it is equipped or not - for me it added the weight when it was unequipped, rather than equipped.

Foundry Version:
0.8.9

Game System:
DnD 5e 1.5.3

Module Version: v0.7.8

The encumbered effect doesn't change the speed of the token. Checking the effects finds that it has no content.

Hello,

It seems that this module doesn't read the option from Inventory+ for "non" custom categories.
In my game, if I enable "Ignore Item Weight" for categories like weapons, equipments and alike. This module still does add the weight of the items in the category to the global weight.

"Powerful Build. You count as one size larger when determining your carrying capacity and the weight you can push, drag, or lift."
Currently everything assumes a medium sized character.
Each size category step increases or decreases (ignoring size Small) carrying capacity by a factor of 2. PHB p176: "Lifting and Carrying"
So just some simple math and a couple lines of code to look for creature size and if they have the powerful build trait flag in the character sheet's special traits.

I noticed that this mod causes some (probably unintended) performance issues, especially with a lot of other modules. It seems the sheet of characters is being updated a whole lot, and with some other modules this adds up.

Removing this module sped up a lot of things for me.

I'm not sure what is causing ut, but seems to have something to do with active affects and the encumberance causing the sheet to render to often.

Using Tidysheet 5e, Newest 5e and latest Foundry.
No matter what I change or update in the module, it's always set to Infinity weight.

In order to submit an effective bug report, please include the following information along with your issue description.

Environment Details

• Foundry VTT Version: 9.249
• Operating System: Red Hat Enterprise Linux (Host), Alpine Linux (Docker container)
• How Are You Using Foundry: Firefox
• Which Game System: dnd5e
• Modules Enabled?: yes, Variant Encumbrance, Item Containers and Dynamic Active Effects

Issue Description

When Variant Encumbrance is configured to use speed penalties, the 10ft penalty is doubled while DAE is enabled, e.g. 30ft movement is reduced to 10ft when lightly encumbered.

See title.

I love the concept of the module, but I have tried using it for months now, and simply find the weight update triggers are incredibly touchy, often times my players will do something that causes 10-20 encumbrance triggers to occur and it turns into a mess.

at least for me, the automation is simply not worth the effort and my players are not changing weight that much for it to be necessary. It would be great to be able to turn off the auto calulation and add a button on the sheet for those who want to manually trigger weight updates/encumbrance effects

Just a heads up, you left Debug on in the module.

Although my players are encumbered, the mod no longer seems to apply any modifiers to speed since 5E 1.2.0

Environment: Foundry VTT 0.7.9
Dnd 5e: 1.2.0

When a user updates their inventory, other players are seeing a popup message stating they lack permission to update Actor.

Tonight I had four players. For the logs shown here, one user added an inventory item from the compendium. They did not see any error. The other three players all saw an error at the same instant.

{"level":"error","timestamp":"2021-01-03 21:28:22","message":"User Mazi lacks permission to update Actor CyUMiEErdVy1M49k","stack":"Error: User Mazi lacks permission to update Actor CyUMiEErdVy1M49k\n    at Function._onUpdate (/var/games/FoundryVTT/foundrycore/resources/app/dist/database/odm/document.js:1:8099)\n    at async Socket.handleEvent (/var/games/FoundryVTT/foundrycore/resources/app/dist/sockets.js:1:2262)"}
{"level":"error","timestamp":"2021-01-03 21:28:22","message":"User Tuesday lacks permission to update Actor CyUMiEErdVy1M49k","stack":"Error: User Tuesday lacks permission to update Actor CyUMiEErdVy1M49k\n    at Function._onUpdate (/var/games/FoundryVTT/foundrycore/resources/app/dist/database/odm/document.js:1:8099)\n    at async Socket.handleEvent (/var/games/FoundryVTT/foundrycore/resources/app/dist/sockets.js:1:2262)"}
{"level":"error","timestamp":"2021-01-03 21:28:22","message":"User Broche lacks permission to update Actor CyUMiEErdVy1M49k","stack":"Error: User Broche lacks permission to update Actor CyUMiEErdVy1M49k\n    at Function._onUpdate (/var/games/FoundryVTT/foundrycore/resources/app/dist/database/odm/document.js:1:8099)\n    at async Socket.handleEvent (/var/games/FoundryVTT/foundrycore/resources/app/dist/sockets.js:1:2262)"}

Disabling VariantEncumbrance plugin stops the error messages so I believe the problem lies here.

This has been reported by myself, Ravenknight and others in the FoundryVTT Discord.

Module Version: v0.6.9

Describe the bug
Since the last update all of the characters in my campaign have massive carrying capacity. For example my Sorceror with a mere STR of 6 is reporting 28.2/1350 lbs.

Foundry Version: 0.8.9

**Game System: DnD 5e 1.5.5 **

Module Version: v0.7.0

My players max weights are at randomly high numbers: 3300, 10,000, etc... The weight calculator otherwise works. If I delete the module, the weight scores fix themselves. But when I reinstall the bug comes right back exactly as it was - no matter how many times i delete it.

To Reproduce
I don't know how to reproduce the error, but it affects every single player character including new ones.

Screenshots

Foundry Version:
Bug happened v8.8 and carried over to 9.2

Game System:
dnd5e

Additional context
Add any other context (like other modules installed) about the problem here.

Below issue is when using: Foundry 0.7.9 / 5E 1.2.2 / Variant Encumbrance v0.3 / Tidy 5E Sheet 0.4.10

Characters (player-owned) always show encumbrance of all items in inventory even when selecting "Equipped" or other filters for encumbrance.

When a filter is selected I receive the following error messages (one or the other, sometimes both) in the console:

Error: Invalid scope for flag categorys
at Actor5e.getFlag (foundry.js:30217)
at convertItemSet (VariantEncumbrance.js:174)
at calculateEncumbrance (VariantEncumbrance.js:330)
at VariantEncumbrance.js:65
at Function._call (foundry.js:2496)
at Function.call (foundry.js:2481)
at Tidy5eSheet._render (foundry.js:4547)
at async Tidy5eSheet._render (foundry.js:5157)

Uncaught (in promise) Error: Invalid scope for flag categorys
at Actor5e.getFlag (foundry.js:30217)
at convertItemSet (VariantEncumbrance.js:174)
at updateEncumbrance (VariantEncumbrance.js:211)
at VariantEncumbrance.js:108
at Function._call (foundry.js:2496)
at Function.callAll (foundry.js:2456)
at Function._handleUpdateEmbeddedEntity (foundry.js:30047)
at Actor5e.updateEmbeddedEntity (foundry.js:30015)
at async Actor5e.updateEmbeddedEntity (entity.js:199)
at async Tidy5eItemSheet._onSubmit (foundry.js:5251)

Hey.-

I was wondering if it would be possible to have an attribute designated to the actor to make the current speed accessible by other modules (I was checking the code and didn't see anything of the sort).

Thanks!

Hello!

First of all, thank you very much for this wonderful module!
After doing some testing in a new world using only this module, I believe I have identified a bug, specifically when preparing/un-preparing spells.

Issue:

Preparing a spell (and maybe other interactions) triggers a call to updateEncumbrance with the spell data as the updatedItem parameter and mode set to add.
The spell data does not contain any weight info, but is added to the item list for weight anyway, later causing the calculateEncumbrance function to always return an encumbranceTier of 0 by introducing NaN values during the process.

Possible Fix:

Quick & Dirty I used for testing: on VariantEncumbrance.js line 235, replace
if (mode == "add") { with if (mode == "add" && !!updatedItem.data.weight) {
Proper Fix: Check the validity of updatedItem, but I'm not sure what valid data should look like so...

Editing my inventory causes a console error:

ReferenceError: SetupConfiguration is not defined
    convertItemSet VariantEncumbrance.js:189
    calculateEncumbrance VariantEncumbrance.js:358
    <anonymous> VariantEncumbrance.js:58
    _call lib-wrapper.js line 1 > eval:4
    call foundry.js:179
    _render foundry.js:2096
    call_wrapped libWrapper-wrapper.js:448
    <anonymous> libWrapper-errors.js:268
    0 libWrapper-wrapper.js:142
    _render foundry.js:2728
    render foundry.js:2003
    render foundry.js:3221
    render foundry.js:9346
    _onUpdateEmbeddedDocuments foundry.js:9473
    _onUpdateEmbeddedDocuments foundry.js:12346
    _handleUpdateEmbeddedDocuments foundry.js:8839
    _updateEmbeddedDocuments foundry.js:8725
    update backend.mjs:153
    updateDocuments document.mjs:365
    update document.mjs:447
    callOriginalFunction Monkey.js:80
    patchCompendiumUpdateEntity patches.js:100
    activateListeners tidy5e-sheet.js:154
    jQuery 9
    activateListeners tidy5e-sheet.js:148
    _render foundry.js:2069
    call_wrapped libWrapper-wrapper.js:448
    <anonymous> libWrapper-errors.js:268
    0 libWrapper-wrapper.js:142
    _render foundry.js:2728
    render foundry.js:2003
    render foundry.js:3221
    render foundry.js:9346
    _onUpdateEmbeddedDocuments foundry.js:9473
    _onUpdateEmbeddedDocuments foundry.js:12346
    _handleUpdateEmbeddedDocuments foundry.js:8839
    _updateEmbeddedDocuments foundry.js:8725
    update backend.mjs:153
    updateDocuments document.mjs:365
    update document.mjs:447
lib-wrapper.js line 1 > eval:8:15
    _call lib-wrapper.js line 1 > eval:8
    call foundry.js:179
    _render foundry.js:2096
    call_wrapped libWrapper-wrapper.js:448
    <anonymous> libWrapper-errors.js:268
    0 libWrapper-wrapper.js:142
    _render foundry.js:2728
    render foundry.js:2003
    render foundry.js:3221
    render foundry.js:9346
    _onUpdateEmbeddedDocuments foundry.js:9473
    _onUpdateEmbeddedDocuments foundry.js:12346
    _handleUpdateEmbeddedDocuments foundry.js:8839
    _updateEmbeddedDocuments foundry.js:8725
    update backend.mjs:153
    updateDocuments document.mjs:365
    update document.mjs:447
    callOriginalFunction Monkey.js:80
    patchCompendiumUpdateEntity patches.js:100
    activateListeners tidy5e-sheet.js:154
    jQuery 9
    activateListeners tidy5e-sheet.js:148
    _render foundry.js:2069
    call_wrapped libWrapper-wrapper.js:448
    <anonymous> libWrapper-errors.js:268
    0 libWrapper-wrapper.js:142
    _render foundry.js:2728
    render foundry.js:2003
    render foundry.js:3221
    render foundry.js:9346
    _onUpdateEmbeddedDocuments foundry.js:9473
    _onUpdateEmbeddedDocuments foundry.js:12346
    _handleUpdateEmbeddedDocuments foundry.js:8839
    _updateEmbeddedDocuments foundry.js:8725
    update backend.mjs:153
    updateDocuments document.mjs:365
    update document.mjs:447

Environment Details

• Foundry VTT Version: 0.8.9
• Operating System: Windows 10
• How Are You Using Foundry: Chrome
• Which Game System: dnd5e
• Modules Enabled?: yes [Inventory+, Item Containers, libWrapper, Variant Encumbrance]

Issue Description

There is currently a calculation issue with this module and the Inventory+ module.
With Inventory+ there is an Inherent Weight option on each inventory category:

This option is intended to simulate the weight of a container item which represents that particular category. For instance, if I have a backpack that weighs 30 lbs, then I can set the Inherent Weight equal to 30. This will in turn increase my total carry weight or encumbrance by exactly 30. This is how the property works without the Variant Encumbrance module installed.

By contrast, the Variant Encumbrance module effectively changes this property, setting it to increase by the entered value for every single item contained within that particular category.

There has been update on how 5e handles speed in foundry. This module should update to account for that. :)

The old attribute is

• data.attributes.speed

The new attributes are:

• data.attributes.movement.walk
• data.attributes.movement.burrow
• data.attributes.movement.climb
• data.attributes.movement.fly
• data.attributes.movement.swim
• data.attributes.movement.units

(Google Translator) I think it would be interesting to have a button on the sheet, a macro or something like that so that the sum of the weights would only be calculated when it was clicked. I say this because if all items are being calculated and any changes happen, it takes a few seconds for the update to occur.
So I think the calculation of items could and applications of dynamic effects could be paused until clicking the button.

When I have this module enabled in 0.7.7, randomly players and GM will lose the ability to access their character sheets. The sheet will come up but clicking Inventory or trying to change anything doesn't work. I am using the Default 5e Character Sheet. Let me know if there's any debug data I can provide to help locate the issue.

Rather than retype everything, here's a discord link, starting from my post with the image of the observant feat:
https://discord.com/channels/170995199584108546/722566083499786352/803675789899071538

After running Find The Culprit, the issue only happens when Variant Encumbrance is active.

The module works perfectly, but doesn't display the encumbrance bar in the inventory tab of the Compact D&D Beyond-like sheet.

Module Version: v0.7.3

Describe the bug
While using the PopOut! module, and with an item container open, I receive an error when increasing and decreasing item quantity beyond encumbrance thresholds.

To Reproduce
Steps to reproduce the behavior:

1. Pop out character sheet
2. Edit container inside of character sheet
3. Add item to container
4. Increase item count until actor becomes encumbered
5. Reduce item count until no longer encumbered
6. Increase item count again
7. See error

Expected behavior
No error should be produced.

Screenshots

Browser:
Chrome

Foundry Version:
0.9.245

Game System:
DnD5e - Fifth Edition System - 1.5.7

Additional context
Only following modules are installed:

• Item Containers
• libWrapper
• socketlib
• Variant Encumbrance+Midi
• PopOut!

Trying to create a DAE feature that doubles the carrying capacity, it enables me to change the flag on the actor, I can read that it is changed, but the encumbrance value and the encumbrance percentage remains the same.

The developer of DAE suggested the above, that VariantEncumbrance is calculating from original data rather than derived, and that is why it is not updating.

Hi,

Variant Encumbrance mod is broken while using with inventory+ mod..

I'm so sad..😢

Module Version: v0.6.8

Describe the bug
Vehicle weight is being calculated when it should not be.

To Reproduce
Steps to reproduce the behavior:

1. Create a Vehicle Actor
2. Set the vehicle's Cargo Capacity to 2 Short Tons
3. Observe the calculated weight now reads N/4 lbs.

Expected behavior
Should not be performing weight calculations for Vehicles.

Screenshots
Vanilla FoundryVTT

With Variant Encumbrance

Browser:

• Brave

Foundry Version: 0.8.9

Game System: DnD5e 1.5.3

Could it be possible to have the option for unequipped item to not be added. My party usually use equipped as "taken on them" and the rest on animals or at home.

I would like to be able to have items effect the waight value apon equip.

can you please add an option to this section that will allow me to effect the waight value

• Foundry VTT Version: 0.8.9
• Operating System: MacOS 11.6
• How Are You Using Foundry: Native Application, Chrome
• Which Game System: dnd5e v1.4.3
• Modules Enabled?: yes

Issue Description

I am using your mod, but when enabling the Special Trait --> Racial Trait --> Powerful Build, the character's carrying capacity is not changing -- it remains the same whether that box is checked or not. I have done enabling/disabling the mod, restarting FVTT, etc.

Environment Details:

Foundry VTT Version: 0.7.1
Operating System: [Linux]
How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]
Which Game System: Dungeons and Dragons 5th Edition, version 0.96
Modules Enabled?: yes
OS, Hosting, Browser (if applicable): Linux/Node/Chrome
Module Version:

Description of the issue:
When the settings "Heavily Enc. Strength Multiplier" is modified the bar color is not correctly setted.

Steps to reproduce the issue:

1. Go to module settings.
2. Set the "Heavily Enc. Strength Multiplier" from "15" to "30"
3. Go to character sheet
4. The bar values seem to have some problem

Here some screenshot:

Default case with "Heavily Enc. Strength Multiplier" set to 15

"Heavily Enc. Strength Multiplier" set to 30

When this module is combined with the "Magic Items" module and a limited number of charges is put on the spell attached to the item, and the item is set to destroy itself, an error message pops up that says the following:

Uncaught (in promise) Error: The key XgBGASnpUdEGFzOT does not exist in the EmbeddedCollection Collection
[No packages detected]
at Map.get (/G:/FoundryVTT/resources/app/common/utils/collection.mjs:106)
at ServerDatabaseBackend._updateEmbeddedDocuments (/G:/FoundryVTT/resources/app/dist/database/backend/server-backend.mjs:1)
at ServerDatabaseBackend.update (/G:/FoundryVTT/resources/app/common/abstract/backend.mjs:153)
at async Socket.handleEvent (/G:/FoundryVTT/resources/app/dist/server/sockets.mjs:1)

Disabling your mod fixes the issue.