Giter Club home page Giter Club logo

dark-plus-material's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

dark-plus-material's Issues

editor.renderLineHighlight: "line" - doesn't work anymore

VSCode Version: 1.12.1
Dark+ Material: 1.0.0

Option editor.renderLineHighlight: "line" is not working anymore. The current line is no longer highlighted with a border, it is only highlighted with a background - it's like having the "all" option enabled.

In "Dark+ Material" is like this:
after
And in "Dark (Visual Studio)" is like this:
before
Before the update, the "line" option worked as in the second image (with border).

Changet text color in HTML

Hello!

Really love your theme. One thing I want to change is the text color in HTML (want to make it white or close to it). Could you please tell me where i can change it?

Atom port of theme ?

I love your theme. Do you know if there exists an Atom port or how much work there is to create one ?

Theme Missing in VSCode - Garuda Linux

Hello, can't find the theme, this is what comes up when I do the search,
image
is there an alternative way of loading up the theme to vscode. I'm using Garuda Linux which probably has something to do with why the error is coming up..

Please help, my code looks like it's not my code ๐Ÿคฆ๐Ÿฝโ€โ™‚๏ธ

VScodium availability

I want to start by saying big thanks for the theme, there is simply no other theme that provides better readability for me. But since few months, your theme is not available in vscodium for some reasons and I'm wondering why is that? All other extensions I use are exactly the same between VS Code and Codium, but your theme. It would be great if it can be installed and updated the same way on codium. Thank you.

Unable to change line highligher

I love this theme but have some vison problems and I am unable to see any lines that I highlight. Is there a way to implement a way to change the highlighted text to something brighter?

Colors seem wrong in version 3+

I have been using this theme for several years and starting with version 3.0.0 the background isn't black anymore. Now it is some grey color. Is this intentional, or is it something I'm doing wrong?

Version 2.4.4
image

Version 3.0.3
image

Add License

Please consider adding a license for posterity. Thanks!

Jupyter Notebook Cell Border Line

Hi Vangware

I love your Dark+Material theme especially with Python,
Since Vs Code Insider released a new version I have lost the "outline cells" of notebook jupyter (in vscode).

I am triying to find it in the "dark-plus-material.json"...
Do you have any hint to give me regarding wich line I could modify to make it wonderful again !?

Thanks you very much

image

Add Terminal Colors

This is a great theme, can you add the following to the color scheme?

terminal.ansiBlack
terminal.ansiRed
terminal.ansiGreen
terminal.ansiYellow
terminal.ansiBlue
terminal.ansiMagenta
terminal.ansiCyan
terminal.ansiWhite
terminal.ansiBrightBlack
terminal.ansiBrightRed
terminal.ansiBrightGreen
terminal.ansiBrightYellow
terminal.ansiBrightBlue
terminal.ansiBrightMagenta
terminal.ansiBrightCyan
terminal.ansiBrightWhite

Git diff background colours do not fit theme

Dark+ Material 2.0.0 with VS code 1.31.1:

image

In my opinion the red and green background colours do not really fit the rest of the theme. This was better in earlier versions. Those colours seem to match the ones from Dark+ (default dark).

I guess this was introduced with version 2.

To compare, here is Dark+ Material 1.4.8 with VS code 1.31.1:

image

This might be a little too saturated. I guess something in between would be good.

Find and Replace popup no longer displaying correctly

On the latest version of VSCode. Just updated today and since the update, the find and replace popup now looks like the below, making it very difficult to see the buttons:

Code_2019-11-16_23-07-10

It works fine when I disable the theme.

Active selection highlight color

Hi there,

Could you kindly consider adjusting the color for active selection highlighting and find match colors?

image

Active selection highlighting color is barely visible against the background.

image

Sometimes it's hard to recognize the find matches.
Even harder is to distinguish if you're having some of the found matches already in active selection.

Otherwise, I just want to express my thanks as this has been my favorite theme for a long time!

Best regards,
Kaedin

Comparing changes lines

Hi Developer,

Currently, with the default settings of Dark+ Material theme it is only possible to detect added or removed lines while in compare mode of selected documents in vscode. For example, other themes are able to visualize changes within the lines via using lighter highlighting color for the changed line and more intense color for the changes. In addition, "Palenight" theme is also applying a distinguishable borderline to inline changes which is looking pretty nice and further highlighting the changed areas.

Dark+ Material currently:
snipaste_2018-06-11_07-52-16

Theme supporting inline change highlighting:
snipaste_2018-06-11_07-56-14

Palenight theme with distinguishable borderlines around each inline change:
snipaste_2018-06-11_09-21-46

Based on these examples, I hope you could find some room for improvement. For example, it would be great if some of these capabilities are also added to Dark+ Material theme:

  • Colorization tweaks to enable inline change detecting
  • If you're not willing to implement borderlines for inline changes, would you know how to customize this on top of the theme?

Also, do you know how would it be possible to invert the highlighting colors in following scenario: I've selected certain string and the original selection is highlighter with lighter color than the other matches found inside the file. I would like to emphasize the original selection via highlighting it with more intense color so that it would pop out more than the other matches.
image

Also, if you know how to enable borderlines for current selection and matches in the current file (not just comparison as given in example above)?

Sorry for asking also such trivial questions and somewhat unrelated to development of the extension!

Best regards,
Kaedin

Wrong colors in Keyboard Shortcuts page

Hi, thanks for creating this color theme. I've been using it ever since I've been using VSCode.

I don't use the Keyboard Shortcuts page much these days so I didn't really mind when I saw that the colors were off a while back,

image

but I needed to use it today and had some time, so I investigated and saw that the reason was that the following color settings weren't being set by this theme: keybindingTable.headerBackground and keybindingTable.rowsBackground.

Of course I can just set it in the workbench.colorCustomizations section to my liking, but I also noticed that some color settings being shipped by this theme like editorOverviewRuler.unicodeForeground are outdated. So after studying its code a bit and found that the color settings come from the base.json file, I presumed that this file is outdated and set out to try and update it for a PR. However, after trying to find where the values come from starting with theme.ts and dark_plus.json, I just couldn't figure out how to generate an updated base.json file.

I'd be happy to make that PR if you could point me in the right direction on how to generate an updated base.json file, or I could just add the color settings I mentioned above to my settings.json if you don't want to update it or support those settings. Either way, thanks for your time ๐Ÿ˜ƒ

HTML: match the color of the symbols <> with the color of the tag name

Hi,
I have a proposal for .html highlighting. I think you could try to change the way that html tags are colored. Right now, the symbols ("<", ">", "/>", "</") are light grey (blueish ๐Ÿ˜…), while the name of the tag is blue.
If the symbols would be also blue, I think you could read easily through the lines, because it would have less variations of colors. Besides that, that light grey is very similar with the grey used for text.

I've attached below a simulation:

before-after

Keep up the good work! This is my favorite theme for some time. ๐Ÿ‘

Highlight color for search should be updated

If you search a HTML tag, the highlight color for search matches with the tags symbols color <>.
Here is an example:
dark-bug
Also, the highlight color doesn't have a good contrast with normal text in HTML files.
dark-bug-2

Error messages are hard to read

The grey text on bright red background is nearly impossible to read and kind of hurts my eyes, too. Is the background color for an exception configurable in VSCode?

screen shot 2017-06-19 at 1 37 54 pm

Cheers,
Trevor Sullivan

Theme doesn't work anymore in version 1.27.2

There is a problem with the theme in the VS Code 1.27.2. It is disabled automatically and you can't reactivated. The button "Reload" is active, but if you click it, it will reload the app, but without any effect. I faced this issue on two different computers today.

[Request] Port Theme to Visual Studio 2019+

Please note this is only a "feature" request and not an issue.

Personally, I prefer using Visual Studio 2019 (Professional) to build applications using C# (because of the Designer) but I've gotten to the point where I design the UI in VS2019 then write the code using VS Code strictly because I like this theme that much. It'd be greatly appreciated if someone could port the theme to Visual Studio 2019 for people like me!

Thank you.

Active file is not highlighted in the sidebar anymore

When you open a file and you click in the code area, the current file should be highlighted in the sidebar, but it doesn't work anymore. Also, when you switch between files, the current file should be highlighted in the sidebar.
This functionality worked in 1.x versions.

Colors in v.3 are far less vivid than in v.2

Don't know what's the reasoning behind changing the colors themes selected by - colors?
I mean, themes are specifically selected because of their, how to say.. colors and changing colors is not something that can improve experience of products selected exclusively thanks to their - colors :)

Anyway, switched back to v.2
Thanks!
BR

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.