valkey-io / valkey-container Goto Github PK

We would also want to automate updating the dockerhub description(overview) with the tags created for a release.

Amazon ECR has a public repository (https://gallery.ecr.aws/) where many developers set as their preferred container registry. There is currently no valkey container image.

valkey-io/valkey#65 (comment): After we have published on docker-hub we would also want to push images on GHCR

• For Docker Hub Doc (refer to https://raw.githubusercontent.com/docker-library/docs/master/redis/README.md)
  • Add links under:
    • Security,
    • start with persistent storage
    • "Using 32 bit instances"
  • Add # Valkey Modules info
  • Add # Image Variants

From valkey-io/valkey#65 (comment): Adding Support for Fedora-based images for Valkey.

How about we support Fedora too? If so, how much overhead will we have to maintain these distributions?
If you one want to contribute to make something better, you are very much welcome.

any reason not to offer an aarch64 image for apple users?

building on my mac m1 works:

FROM debian
ARG VERSION=7.2.5-rc1

RUN useradd -ms /bin/bash valkey
WORKDIR /home/valkey

# install prerequisites
RUN apt update &&\
    apt install -y build-essential pkg-config wget &&\
    rm -rf /var/lib/apt/lists/*

# install from source
RUN wget https://github.com/valkey-io/valkey/archive/refs/tags/${VERSION}.tar.gz -O valkey-${VERSION}.tgz &&\
    tar -xf valkey-${VERSION}.tgz

RUN cd valkey-${VERSION} &&\
    make &&\
    make install

USER valkey

docker build --platform=linux/aarch64 -f Dockerfile -t valkey/custom-aarch64:latest .
docker build --platform=linux/amd64 -f Dockerfile -t valkey/custom-amd64:latest .

With some manifest amends it would therefor be easy to have image support. Same could be done with alpine or other base images instead of debian.

Of course I could create some custom images and upload them to dockerhub but i would rather prefer having some from the real project. I am not 100% familiar with the workflow you're using to generate the existing images but in case you need extra hands let me know.