Giter Club home page Giter Club logo

todo-list-js's Introduction

ToDo-List-JS

Members

  • Carlos Sandoval
  • Valeria Vassallo
  • Brayan Ciudad
  • Lian Nivin
  • Diego Cuevas

Rules

Version 1: Friday 9 p.m.

Each member must have a 1 pull request.

Nothing new after Sabado 10 p.m.

Checkpoints

Create task: Message, Due Date ( deadline )

List task: include checkbox if task is complete

Sort by:

Message

Due Date

Created Date

Priority

Optional

Mark a task as priority

todo-list-js's People

Contributors

cdsandoval avatar diegocuevas avatar linzeur avatar valevassallo avatar

Watchers

 avatar  avatar  avatar

Forkers

cdsandoval

todo-list-js's Issues

Feedback

https://github.com/valevassallo/ToDo-List-JS/blob/master/index.html#L34Type submit is not required, is the default type in a button tag.

https://github.com/valevassallo/ToDo-List-JS/blob/master/index.html#L31
A search input should be of type search

https://github.com/valevassallo/ToDo-List-JS/blob/master/index.html#L36
If that is a form it should use a form tag, not a div.

https://github.com/valevassallo/ToDo-List-JS/blob/master/index.html#L50-L53
It should internally use radio buttons.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L1
This should be listTasks, always use camel case in JS.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L26-L27
Use camelCase always in JS.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L73
Try to avoid inline JS code, you could use event listeners on the parent to capture the events of the child.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L87
I recommend here passing the value directly and make validateTask unaware of the DOM.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L94-L100
You are not returning the mapped list, why use map then?

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L115-L119
You are not saving the sorted list in a variable or constant.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L121
You are not saving the reversed list in a variable or constant.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L148
Use camel case.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/js/index.js#L148-L155
This should have been a filter method, not a forEach.

https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/css/styles.css#L35
https://github.com/valevassallo/ToDo-List-JS/blob/master/resources/css/styles.css#L106
Is there more than one button? Why not add a class to the button?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.