vak / makefile2dot Goto Github PK

I am actually coming from the fork at https://github.com/chadsgilbert/makefile2dot, which is linked by the PyPI page at https://pypi.org/project/makefile2dot/. However, there I cannot create issues and I am assuming, that the same issue persists in this repository:

In Makefiles one can assign variables locally for only one target. For example:

target1: SOME_VAR := some_value
target1:
    printf "%s\n" "${SOME_VAR}"

When this kind of Makefile is input for makefile2dot, then makefile2dot fails:

$ makefile2dot
Traceback (most recent call last):
  File "LOCATION_OF_MYVENV/bin/makefile2dot", line 23, in <module>
    makefile2dot(direction=ARGS.direction, output=ARGS.output, view=ARGS.view)
  File "LOCATION_OF_MYVENV/lib/python3.10/site-packages/makefile2dot/__init__.py", line 71, in makefile2dot
    graph = build_graph(stream_database(), direction=direction)
  File "LOCATION_OF_MYVENV/lib/python3.10/site-packages/makefile2dot/__init__.py", line 39, in build_graph
    target, dependencies = line.split(':')
ValueError: too many values to unpack (expected 2)
make: *** [Makefile:385: makefile-graph] Error 1

makefile2dot does not take local variable assignment syntax into account and runs into an error.

I realize you're probably not interested in maintaining this program any more, but just in case: I downloaded a copy and made a couple changes to make it work better. First, changed the print statements to Python3 (actually, to stderr.write(...) statements).

More importantly, I added code to chop off comments (which were being interpreted as if they were makefile code), and to escape '%'. I'm not sure why the latter is necessary, but without it "%.foo" turns into something like "%27". The line in question was
line_to_emit += line
and is now
line_to_emit += line.split('#')[0].replace('%', '\%')

There are some other things going on that I haven't been able to pin down, but as you say, it was experimental...