vaelen / iot Goto Github PK

As I mentioned, this is really nice! I've written my own but I spent a lot of my time working around the password problem (I guess I should have forked the code, as you did); there are a lot of nice details in your code.

Some ideas if you are interested:

• I made the top-level client an interface, to facilitate mocking.
• I have a utility function which sets mqtt.DEBUG, mqtt.WARN, ... etc so that if you need it you can get the underlying MQTT debug information.
• I opted for now to expose the MQTT token to callers, because I wasn't sure if a fixed timeout would be the right thing. Dunno if that's really a good idea or not. I guess I could wrap the token to make it less ugly.

Anyway, well done.