vacuumlabs / adalite Goto Github PK

It would be nice to be able to store your wallet in your computer as an encrypted JSON. We can replicate the way Daedalus does it currently, so the wallet would be importable this way in Daedalus, too.

addresses and transaction IDs (or some icons nearby) should be clickable

Currently, variable names such as walletSecretString are quite misleading because they hold a complex type instead of string. Trezor uses HDnode for the equivalent variables. One other option would be to simply use node

This modal should show the user the mnemonic and tell him to write it down. The user then can close the modal, insert the mnemonic into the input and load the wallet

I would like to suggest that if you are running app in dev mode (yarn dev) then it would be nice if all try-catch blocks would not swallow errors, because if you are developing the app, you actually want to see them.

Hi, having this seed: category age design kid snow ketchup give upper toe destroy various concert

I got this address in cardanolite: DdzFFzCqrht1aN3AUTDGqYyMsSyTJ2ELePqzwc4xruCqjY3MxXDddLb4UFpYWxwHUAGRDkt9ZCGi3HiVKxk8J1wqYs9DcnPXM62zirrS

But this one in Daedalus: DdzFFzCqrht9rXNV1cKD8gmVpi1WZa3cGGrm5i5S3XWaiWs8jMR8kMZwx395J5zLYmrE4HnRRQhdAYEUmP5YXvGPYJKWB18uvfsCSiqa

Is it possible to match the one generated by Daedalus in cardanolite?

Is there any method exposed that allows address derivation from Xpub?

Add a waring stating that the mnemonic is the only way to access your wallet funds

The pop-up takes up all the screen and a new user can be discouraged to proceed.

We currently rely on the cardanoexplorer API which can start being limited at any time. Moreover, the API does not provide any efficient way to retrieve unspent transaction outputs for an address, therefore we have to iterate through all the transaction history of an address which may be a problem for addresses with many movements.

The best solution that comes to my mind is to fork the cardano blockchain explorer https://github.com/input-output-hk/cardano-sl/tree/master/explorer and add the missing functionality or to submit an issue with the request to add the aforementioned functionality.

just meditate over it for 2 hours or so.

This pattern looks nice: https://getbem.com/introduction/

When I run the test it take about 8s it looks suspicious.

Currently we are working too much with state.sendAmount.fieldValue which is a string. Ideally, this value should be converted to int (i.e. micro Adas) at a single point of the code to avoid inconsistencies related with float arithmetics. The displaying of amounts should be unified as well, perhaps by some formatting function that takes integers and outputs a properly formatted amount.

If I enter civil void tool perfect avocado sweet immense fluid arrow aerobic boil flash civil void tool perfect avocado sweet immense fluid arrow aerobic boil flash boil flash house, the wallet allows to "login" but it will get stuck on loading screen with error in console Uncaught (in promise) Error: Invalid mnemonic checks

The date is now in the format DD.MM.YYYY which is not international, should be fixed.
Also the whole date and time takes too much place on mobiles.

Let's first discuss how do we want it.

https://developers.google.com/web/progressive-web-apps/

Small cleanups:

• we can streamline Buffer usage from new Buffer('02', 'hex') --> new Buffer([0x02]) for one-byte buffers

• more 'hex' reducements, e.g., new Buffer(hmac1.digest('hex'), 'hex') should not need double conversion through hex

• refactor walletSecretString.getPublicKey() to return buffer instead of hex (most of the time when we use it we get Buffer out of it back). Again, this will save some hex-double-conversion madness

• deriveSK is never used with childIndex = 0x80000000, change if -> assert

• Suggestion: replace function getCheckSum(input) in address.js with const crc32Unsigned = (inp) => crc32.buf(inp) >>> 0;

• we can streamline blake2 usage (according to https://github.com/dcposch/blakejs oneliner should work)

add the ability to access the wallet by trezor or keyfile to the home screen gui.

When you click on dashboard, send and receive link and then you try go back with browser button, url will change but app will not render previous screen

some claims there are outdated or should be reworded. amount of lines, dependencies, bundle size comparison vs Daedalus, ...

Things to do:

• Tiles on top

• try adding fourth tile -> "Hardware Wallet" - put trezor icon and a caption saying "We are currently the only Cardano wallet supporting a hardware wallet - Trezor Model T". If it does not fit, I would remove the "No lock in" tile.

• Stats

• remove "stats" (it's outdated and hard to maintain)

• Why Adalite

• "Extremely lightweight" - update 3Mb with "less than 500kB"

• remove "Provably secure" section

• add "Hardware wallet support" section - put trezor icon and put a text saying "We support Trezor Model T, one of the safest options to store your funds." (feel free to improve it)

For example when you are sending ada, you do not see your balance

We are tracking page visits, but we aren't filtering robots. It would be nice to filter them to get more insightful stats.

Trezor currently checks transactions leading to the unspent outputs referenced in the submitted transaction to avoid losing funds to unexpectedly high fees if the sender manages to "lie" about the actual amounts of coins in the inputs. Mnemonic crypto provider should do the same check.

When I reload the landing page https://cardanolite.com/ and I scroll down, the tiles under the "try the alpha now" button partially fade which seems weird. Happened on Chrome 66.0.3359.139, but only sometimes, like 1/3 - 1/4 of attempts.

I'm having an error in deriveAddressWithHdNode,
Here is my piece of test code

const mnemonicAPI = require('./wallet/mnemonic');
const addressAPI = require('./wallet/address');
const transaction = require('./wallet/transaction');

const men = mnemonicAPI.generateMnemonic();

console.log(men);

const hdnode = mnemonicAPI.mnemonicToHdNode(men);
console.log(hdnode);


console.log(hdnode.extendedPublicKey.toString('hex'));

const address = addressAPI.deriveAddressWithHdNode(hdnode, '0x1').then(()=>{}).catch((err)=>{console.log(err)});

Upon inspecting it looks like hdNode.getExtendedPublicKey() returns a Buffer but pbkdf2 function is throwing for some reason.
Might be happening coz of this pull-request browserify/pbkdf2#77

If I change the getExtendedPublicKey function to return a string instead of the buffer, It works. But is it okay and valid in terms of cardano?

  getExtendedPublicKey() {
    return this.extendedPublicKey.toString('hex');
  }

On a mobile device (e.g. iPhone SE), when you click on menu and choose some of the tabs, the menu sidebar stays there and you can't see anything.

It would be nice to have an FAQ on the page, that would explain the differences from Daedalus in more detail and the overall interoperability and other stuff related to using the wallet.

• decide how we want to define 'key' for DOM element (key? data-key? class / id?)
• do 'smart DOM replaement', it's enough to do this for the controls we actually use (i.e. inputs.. anything else?)
• take your time and try to produce high quality code (even if not necessarily solving everything)

Currently we assume that all the output addresses have a certain amount of bytes which is not true. We should consider the exact output addresses when estimating the transaction size.

• try to forbid object spread and possibly other features not working in all major browsers
• if browser is not supported one (define what this means), display warning