Giter Club home page Giter Club logo

Comments (7)

Saulis avatar Saulis commented on August 23, 2024

@JouniK We need your input on this. We did have a prototype using <vaadin-grid>, but we we're thinking if we should use <iron-list> instead? What do you think? At least a prototype?

from vaadin-combo-box.

jouni avatar jouni commented on August 23, 2024

Yeah, I’d like to try it out. Do you have any estimate how long it would take to build the lazy-loading on top of iron-list, to get it as solid as with the grid? The only things we would miss from the grid would be multiple column support (and headers/footers). And some accessibility stuff, like the automatic reshuffling of the TR elements once you stop scrollling (helps screen readers to read the elements in the correct order).

from vaadin-combo-box.

Saulis avatar Saulis commented on August 23, 2024

I guess we can take some hints from the iron-lists demo: https://elements.polymer-project.org/elements/iron-list?view=demo:demo/collapse.html&active=iron-list (on my phone right now so cant see how the demo source looks like)

For multiple columns, isnt the template model in iron-list sufficient?

from vaadin-combo-box.

jouni avatar jouni commented on August 23, 2024

Full-blown columns is a little bit more than just some divs and CSS. But
it’s not something we need for 1.0.

And instead of spending time figuring out lazy loading, I would like us to
polish the component in all other ways before that. So all the other end
user features should be higher priority that these highly technical ones.
On ma 26. lokakuuta 2015 at 12.14 Sauli Tähkäpää [email protected]
wrote:

I guess we can take some hints from the iron-lists demo:
https://elements.polymer-project.org/elements/iron-list?view=demo:demo/collapse.html&active=iron-list
(on my phone right now so cant see how the demo source looks like)

For multiple columns, isnt the template model in iron-list sufficient?


Reply to this email directly or view it on GitHub
#26 (comment)
.

from vaadin-combo-box.

Saulis avatar Saulis commented on August 23, 2024

Yeah, I guess the main motivation here was to try if iron-list would be a more light weight and smoother option also from the users perspective. I did a quick test run using iron-list, here's some observations:

  • Was originally assuming that firstVisibleIndex in <iron-list> has notify:true and it could be used to trigger loading items. This was not the case, had to register a crude event listener to listen to mousewheel events instead and use an event handler to check the firstVisibleIndex
  • Scroll bars show the height depending on the items property, and not the actual datasource size like in <vaadin-grid>
  • The actual implementation was fairly easy, just using firstVisibleIndex to determine how many items we need to have loaded, then binding the needed item count parameter in <iron-ajax> and the hooking a on-response handler to append the new items to the items property of the iron-list

That said, considering the scroll bar issue and the way events need to be handled, it's probably better to go ahead with <vaadin-grid> at this point.

from vaadin-combo-box.

Saulis avatar Saulis commented on August 23, 2024

Iron-list 1.2.0 introduces support for https://github.com/PolymerElements/iron-scroll-threshold which helps a lot in making a lazy loading implementation.

See also #128

from vaadin-combo-box.

Saulis avatar Saulis commented on August 23, 2024

Closing the issue for now as it's not relevant currently.

from vaadin-combo-box.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.