uweschaefer / wicket-modelfactory Goto Github PK

Codacy detected an issue:

Message: Position literals first in String comparisons

Occurred on:

• Commit: 2a80520
• File: wicket-modelfactory/src/test/java/org/wicketeer/modelfactory/ConcurrentModelFactoryStorm.java
• LineNum: 90
• Code: if (!b.equals("b")) {

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/test/java/org/wicketeer/modelfactory/ConcurrentModelFactoryStorm.java
• LineNum: 97

Codacy detected an issue:

Message: Position literals first in String comparisons

Occurred on:

• Commit: 32aed9c
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ProxyArgument.java
• LineNum: 55
• Code: if (name.equals("notifyAll")) {

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ProxyArgument.java
• LineNum: 57

Codacy detected an issue:

Message: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Occurred on:

• Commit: 7cf847c
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ArgumentsFactory.java
• LineNum: 222
• Code: private static LastArgHolder ARG = new LastArgHolder();

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ArgumentsFactory.java
• LineNum: 222

Codacy detected an issue:

Message: Position literals first in String comparisons

Occurred on:

• Commit: 32aed9c
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ProxyArgument.java
• LineNum: 49
• Code: if (name.equals("wait")) {

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ProxyArgument.java
• LineNum: 51

We observe this when creating a Propertymodel with modelfactory for bean properties involving enums

To reproduce, start sample project at https://github.com/tkruse/modelFacEnum

Codacy detected an issue:

Message: An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.

Occurred on:

• Commit: 7f2336d
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/Invocation.java
• LineNum: 95
• Code: if (e instanceof RuntimeException) {

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/Invocation.java
• LineNum: 95

currently we look at the load method which is tricky.

Codacy detected an issue:

Message: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Occurred on:

• Commit: 7cf847c
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ArgumentsFactory.java
• LineNum: 234
• Code: private static final Objenesis objenesis = new ObjenesisStd(true);

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ArgumentsFactory.java
• LineNum: 234

When running our unit tests, we get:

java.lang.NoSuchMethodError: org.apache.wicket.request.cycle.RequestCycle.setMetaData(Lorg/apache/wicket/MetaDataKey;Ljava/lang/Object;)Lorg/apache/wicket/request/cycle/RequestCycle;
    at org.wicketeer.modelfactory.RequestCycleLocal.set(RequestCycleLocal.java:76)
    at org.wicketeer.modelfactory.RequestCycleLocalFrom.set(RequestCycleLocalFrom.java:57)
    at org.wicketeer.modelfactory.ModelFactory.from(ModelFactory.java:291)
    at accounts.AddressEditPanel.createStreetAndNumber(AddressEditPanel.java:80)

This exception looks dodgy, involving code paths that don't seem to have changed since 0.9.3, maybe jar was compiled differently?

please ignore...

Hello,

first of all, great library. My question is how can i connect a ValueMap with wicketeer?

In normal wicket it is:

new PropertyModel<String>(captchaModel.getObject().getProperties(), "captchaInput")

where 'captchaModel.getObject().getProperties()' is a ValueMap.

Cheers

Codacy detected an issue:

Message: Position literals first in String comparisons

Occurred on:

• Commit: 32aed9c
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ProxyArgument.java
• LineNum: 46
• Code: if (name.equals("finalize")) {

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/main/java/org/wicketeer/modelfactory/internal/ProxyArgument.java
• LineNum: 48

Codacy detected an issue:

Message: Position literals first in String comparisons

Occurred on:

• Commit: 2a80520
• File: wicket-modelfactory/src/test/java/org/wicketeer/modelfactory/ConcurrentModelFactoryStorm.java
• LineNum: 111
• Code: if (!path.equals("b.e")) {

Currently on:

• Commit: 67d47a0
• File: wicket-modelfactory/src/test/java/org/wicketeer/modelfactory/ConcurrentModelFactoryStorm.java
• LineNum: 121

MF needs to detect final methods when trying to create an ad hoc proxy. problem is, we probably should not warn for just any final method, because maybe it never is called. on the other hand, once a method is called, it is too late.

open for suggestions here.

Kudos for finding this one go to R.Kuehne

Current modelfactory supports only Wicket 6. It would be nice to support the Wicket 7 also.