Giter Club home page Giter Club logo

directus-extension-upload-limiter's People

Contributors

dominic-marcelino avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

rvizzoca

directus-extension-upload-limiter's Issues

Bug: delete-filter updates user-data to early

If a file should be deleted, the extension updates the data in the files.delete filter (before the action happens).
This is necessary because after deletion the filesize is not available anymore (obviously!)

Problematically the deletion can be prevented afterwards by another filter or database constraint. In this case the extension-data have been already updated in the user profile.

Steps to recreate

  • Add a collection with a relation to files, add a constraint to prevent the file deletion
  • Move over to files and try to delete the file
  • The deletion is blocked by the constraint
  • The profile was already updated falsely!

Possible solutions:

  1. Get the data in the files.delete filter but only update the userprofile in the action (after deletion)
  2. Run like this, but also store the last changes. In case the deletion does not succeed, revert them
  3. Open a PR to Directus to add the File-Object to the delete event (best solution!)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.