utagai / gallery Goto Github PK

This will benefit from the natural parallelism of how browsers make requests for URLs in the HTML of a page. Currently, we serially insert the base64 encoding of every image into the HTML file, so the page load takes a while for a large selection of images.

This gives disk access to API callers, so we must be careful to limit the surface area of the filesystem that can be touched with this endpoint.

If you rename a file, gallery won't pick it up. It'll only pick up file adds/deletes. I think this is because of the event mask we pass to inotify.add_watch() here.

We should log when inotify triggers on watched file directories.

Currently, we simply pay an initial start-up cost of iterating the given directories and holding onto their paths/bytes (with #1, we should no longer need to hold onto the images themselves in memory).

This works, but does not work if new images are added to the watched directories or if old images are removed. We should use inotify to watch for these change events and update the internal representation of the gallery accordingly.

If this is done before #1, then we'll also have to track modification events and update the bytes we store for each image.