usrflo / registered-domain-libs Goto Github PK

Just wanted to tell that TLD Array in registered-domain-libs/PHP/effectiveTLDs.inc.php get empty in this commit d76e2a3

Might be by mistake.

Hi,
is that normal that none of amazonaws.com hosts are found ?
ex: kinesis.us-east-1.amazonaws.com
each time it gives NULL

bye Fred

As mentioned in publicsuffix/list#1872 (comment)

Multiple psl libraries share the same bug while handling wildcards.

I went over all the FOSS implementations in https://publicsuffix.org/learn/ , and I found 3 of them behave funny for wildcard domains. In particular:

• regdom-libs
• publicsuffix2
• publicsuffixlist.js

Seems to all mislabel eTLD-n x [eTLD minus n] (with n from 0 to infinite), as an eTLD, if another eTLD y is defined as a subdomain of that x eTLD-n.

As an example publicsuffix2 behaviour with the following patch:

 // Linode : https://linode.com
 // Submitted by <[email protected]>
 members.linode.com
-nodebalancer.linode.com
+*.nodebalancer.linode.com
+*.linodeobjects.com
+ip.linodeusercontent.com

Example here:

In PHP 5.4 gives errors in the document regDomain.inc.php, as line 42
$ signingDomainParts = split .....;
is obsolete.
I propose to change this string instrument regDomain.inc.php (PHP version) to:
The highlighted line in the picture-

Line 42.

It seems any IDN can't get past the regexp in regDomain.class.php:

if (!preg_match("/^([a-z0-9])(([a-z0-9-])*([a-z0-9]))*$/", $domPart)) return FALSE;

If anybody's interested, the library could be augmented to support UTF8 letter characters by adding the \p{L} character set along with a-z0-9 and adding /u at the end:

if (!preg_match("/^([a-z0-9\p{L}])(([a-z0-9-\p{L}])*([a-z0-9\p{L}]))*$/u", $domPart)) return FALSE;

I tested it as such and it worked:

echo (new regDomain())->getRegisteredDomain("example.мон", false);

And it works for that IDN (.xn--l1acc):

example.мон

I could submit a pull request if nobody sees an issue

require_once("registered-domain-libs/effectiveTLDs.inc.php");
require_once("registered-domain-libs/regDomain.inc.php");

getRegisteredDomain('subdomain.domain.co.uk');
// this print "co.uk"
getRegisteredDomain('subdomain.domain.co.uk', $tldTree);
// this print "co.uk"