Comments (2)
- Is there a way to know inside After() whether an Action() has failed so that any subsequent business logic doesn't execute?
The cli library itself does not provide any mechanism to do this. You can implement it on your own.
- Are there any specific reasons as to why After() was designed to suppress panics and execute regardless?
No panics are not suppressed. However After() is added as a deferred function to the command processing logic so it will execute even if Action() panics. That is golang standard behaviour. This allows the defer function to suppress/manage the panic and continue or abort.
- I had an os.Exit(0) inside After() which prevented any stack traces from being printed, so it took forever to figure out that there was a panic happening. Should it be explicitly documented that os.Exit(0) should not be used at all?
Generally you shouldnt be using os.Exit() at all, you either return an err or nil to the corresponding Action()/Before()/After() funcs and the cli library will handle the rest.
from cli.
However After() is added as a deferred function to the command processing logic so it will execute even if Action() panics
Generally you shouldnt be using os.Exit() at all, you either return an err or nil to the corresponding Action()/Before()/After() funcs and the cli library will handle the rest.
This has to be explicitly stated in the docs then. Will send a docs PR sometime soon. Thank you.
from cli.
Related Issues (20)
- Issue with object being nil in action function HOT 2
- Custom Environment Variables Setup HOT 3
- PersistentFlags support HOT 6
- v2: if custom subcommand completion is provided, completing after partial flag input panics HOT 5
- Compatibility for cli.Context and context.Context HOT 2
- IsSet breaks with Persistent option HOT 3
- [v3] `Required` does not work with `Persistent` HOT 2
- [v2] Is there any way to customize the format of flag's help text? HOT 7
- [v3] Missing `Required` flags show alias rather than primary name HOT 2
- [v3] `Validator` seems to always receive the empty string HOT 4
- [v3] Long flag usage text uses short flag syntax HOT 2
- [v3] how to chain multible Sources? HOT 11
- Execute `runFlagActions` before `c.Before` HOT 3
- `cli.UintSliceFlag` flags do not implement the `ActionableFlag` interface despite having an `Action` field
- Generate markdown from help HOT 3
- SliceFlagSeparator can affect subcommands, whereas DisableSliceFlagSeparator does not. HOT 1
- v3 MutuallyExclusive flags are not included in help text HOT 7
- FullName not working as it did in 2.19.3, seems to have broken in 2.20.0 HOT 3
- Categories with no visible flags are still visible HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.