Comments (6)
This is basically reopening #692 since that was closed due to folks not understanding what persistent flags are. They are NOT about "saving a flag that was set in the previous invocation of the cli".
from cli.
Some might think you can just use common flags on the root command and sub commands to get this to work, but sadly it does not. The following test currently fails:
package test
import (
"github.com/urfave/cli/v2"
"testing"
)
func TestCommonFlags(t *testing.T) {
commonFlags := []cli.Flag{
&cli.StringFlag{
Name: "result",
},
}
result := ""
app := &cli.App{
Name: "root",
Flags: commonFlags,
Commands: []*cli.Command{
{
Name: "sub",
Flags: commonFlags,
Action: func(ctx *cli.Context) error {
result = ctx.String("result")
return nil
},
},
},
}
if err := app.Run([]string{"root", "sub", "--result", "after"}); err != nil {
t.Fatal(err)
}
if result != "after" {
t.Fatalf("result is not after")
}
if err := app.Run([]string{"root", "--result", "before", "sub"}); err != nil {
t.Fatal(err)
}
if result != "before" {
t.Fatalf("result is not before")
}
}
from cli.
@chirino Support for persistent flags was added in v3. Please try with that. You can mark a flag explicitly as persistent in which case it will be allowed in subcommands as well.
from cli.
@chirino I am closing this for now. If you see any problems with persistent flags in v3 we can create a new issue
from cli.
Thanks! I Tested v3 out and it's working nice.
from cli.
Well mostly working.. found this bug: #1826
from cli.
Related Issues (20)
- Issue with object being nil in action function HOT 2
- Custom Environment Variables Setup HOT 3
- Question about panic -> `After()` behaviour HOT 2
- v2: if custom subcommand completion is provided, completing after partial flag input panics HOT 5
- Compatibility for cli.Context and context.Context HOT 2
- IsSet breaks with Persistent option HOT 3
- [v3] `Required` does not work with `Persistent` HOT 2
- [v2] Is there any way to customize the format of flag's help text? HOT 7
- [v3] Missing `Required` flags show alias rather than primary name HOT 2
- [v3] `Validator` seems to always receive the empty string HOT 4
- [v3] Long flag usage text uses short flag syntax HOT 2
- [v3] how to chain multible Sources? HOT 11
- Execute `runFlagActions` before `c.Before` HOT 3
- `cli.UintSliceFlag` flags do not implement the `ActionableFlag` interface despite having an `Action` field
- Generate markdown from help HOT 3
- SliceFlagSeparator can affect subcommands, whereas DisableSliceFlagSeparator does not. HOT 1
- v3 MutuallyExclusive flags are not included in help text HOT 7
- FullName not working as it did in 2.19.3, seems to have broken in 2.20.0 HOT 3
- Categories with no visible flags are still visible HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.