urbanriskmap / cognicity-reports-telegram Goto Github PK

I propose we have a single repo for reports lambdas, reasons:

• Avoid duplicating shared licence files, README instructions, npm dependencies, serverless.yml config (part) incl. environment variables like DB (store separately, add that file to .gitignore and read in to avoid these going into github).
• May well be some shared code too.
• Deploy all or single function updates from serverless.yml
• Avoids having lots of little repos. Lambdas are small.

Negatives:

• Need to be clear in raising issues as to where the problem is / what lambda the feature request is for.

In case of user selecting an unsupported location, should we disable report submission client-side or catch 'undefined' city param in server / reports modules?

• unit tests for core functionality