urbanriskmap / cognicity-rem Goto Github PK

• Promise.all results in a race condition when getting new states from the server after a delete all flood states is called
• the client updates the flood states before all delete requests have completed (see attached screenshot).

code here also needs changing in line with urbanriskmap/cognicity-server#74

Unhandled rejection e@https://rem.petabencana.id/scripts/vendor-bundle.js:7:17827
invoke@https://rem.petabencana.id/scripts/vendor-bundle.js:3:22805
get@https://rem.petabencana.id/scripts/vendor-bundle.js:3:16771
invoke@https://rem.petabencana.id/scripts/vendor-bundle.js:3:19458
invoke@https://rem.petabencana.id/scripts/vendor-bundle.js:3:22761
get@https://rem.petabencana.id/scripts/vendor-bundle.js:3:16771
invoke@https://rem.petabencana.id/scripts/vendor-bundle.js:3:19648
invoke@https://rem.petabencana.id/scripts/vendor-bundle.js:3:22761
get@https://rem.petabencana.id/scripts/vendor-bundle.js:3:16771
https://rem.petabencana.id/scripts/vendor-bundle.js:11:20805
i@https://rem.petabencana.id/scripts/vendor-bundle.js:2:22129
_settlePromiseFromHandler@https://rem.petabencana.id/scripts/vendor-bundle.js:2:10596
_settlePromise@https://rem.petabencana.id/scripts/vendor-bundle.js:2:11420
_settlePromise0@https://rem.petabencana.id/scripts/vendor-bundle.js:2:12110
_settlePromises@https://rem.petabencana.id/scripts/vendor-bundle.js:2:13441
_drainQueue@https://rem.petabencana.id/scripts/vendor-bundle.js:1:7981
_drainQueues@https://rem.petabencana.id/scripts/vendor-bundle.js:1:8038
drainQueues@https://rem.petabencana.id/scripts/vendor-bundle.js:1:6160
promiseReactionJob@[native code]

While using pagination fixes the issue of selected area not showing up sometimes in the first few rows, wouldn't it be more useful to sort areas based on reports?
Sorting by name could be secondary.

Sometimes this happens, sometimes not.

Canvas rendering is much faster in browser than SVG.

• Leaflet 1.0 may use this by default, in earlier versions like 0.7 it had to be enabled.
• Investigate using explicit canvas layers to render, hide and show updates to flood extents data

• this is why the clear states function cannot be used with a Leaflet clearLayer()
• may actually be quicker to get the GeoJSON stack again and re-render than join on the fly, since the map is effectively stateless.

aurelia-testing.js:1 Uncaught SyntaxError: Unexpected token <

should we add scripts/ to .gitignore and remove?

I've tried tweaking the map extents in 6d9ba70 to better centre and focus on Semarang in initial map display. However on first load it does this two step process of using the map extents I specify (with some cut off by table), but then zooms in and cuts off the bottom of Semarang:

Then on selecting regions, sometimes these are cut off at the bottom (as shown) or entirely off the bottom of the screen. Resizing the browser window fixes this particular issue but then both issues show up on page reload.

OS: macOS 10.14.2
Browsers: Chrome beta 71.0.3578.62, Firefox Developer Edition 64.0b11 (64-bit)

• UI elements should scale on window resize
• Ratio between map and table should be user configurable

_V3 CogniCity removed reports module as part of UI/UX improvements for public map, but there may be a case of integrating this back into the REM.

• Requires discussion

Currently auth0-lock is being brought in with a script tag on index.html, but this means that karma can't bring it in during testing, failing with:

Chrome 56.0.2924 (Mac OS X 10.10.5) the app says hello FAILED ReferenceError: Auth0Lock is not defined at new App (/Users/abrahamq/Documents/urop/cognicity-rem/scripts/app-bundle.js:214:23) at Object.<anonymous> (/Users/abrahamq/Documents/urop/cognicity-rem/test/unit/app.spec.js:6:14)

I think the solution is to bundle auth0-lock with our app. There's an npm module https://www.npmjs.com/package/auth0-lock, but I couldn't get it to work? There's no dist/ or build folder in the npm module and the docs seem to point at having to build the module but npm install fails.

Hi all,

We have a problem when you logged in to REM, sometimes Auth0 recognized you as basic user (View Only) although you're not.

Here's an example with BPBD account:

BPBD account - View Only

but then after several tries - Full Access

The same thing also happens with my own account.

Temporary solution to gain full access:

1. Login to REM
2. Close tab
3. Open REM page again
4. Click 'Peta' (Map)

• can't refresh layer symbology because of #7
• could perhaps trigger a redraw through a simulated UI even (e.g. click) for every area that's being deleted.

graphic display color seems inconsistance.
action: coloring the RW map on 4 different flood criterias (red, orange, yellow, purple).
REM editing shows:

public map shows:

both using dev version

In map.js

layer._leaflet_id = feature.properties.area_id;

This breaks standard leaflet functionality like layer.clearLayers().

We'll need to refactor the REM map/table code to fix this.

I can't load the page in IE. I am having trouble with the VM so I can't screenie or copy and paste the error but it did suggest it was having trouble with polyfill and suggested using fetch, so I will give that a shot.

Now strictly unavailable as of two days ago:
https://auth0.com/docs/migrations/guides/legacy-lock-api-deprecation

FY17Ext Dev Meeting Field Office 12 _ request to correct bug that shows a 7 hour difference between the real report time and its display in the REM.

See detailed description:
urbanriskmap/riskmap#221 (comment)

• investigate whether we can fix the timestamps to be ICT/WIB.
• note we're currently using the version of Chart.js bundled with Moment.js because of issues of getting stand alone moment to work in Aurelia.

Will address
https://travis-ci.org/urbanriskmap/cognicity-rem/builds/207609977

Firefox 51.0.1 (64-bit) on OSX 10.11.6

------------------------------------------------
Inner Error:
Message: Auth0Lock is not defined
Inner Error Stack:
App@https://rem-dev.petabencana.id/scripts/app-bundle.js:214:7
invoke@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12420:14
invoke@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12379:155
invoke@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12643:16
get@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12096:27
get@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12582:14
ensureViewModel/<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:24085:58
tryCatcher@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:3373:16
[15]</module.exports/Promise.prototype._settlePromiseFromHandler@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:2590:13
[15]</module.exports/Promise.prototype._settlePromise@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:2647:13
[15]</module.exports/Promise.prototype._settlePromise0@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:2692:5
[15]</module.exports/Promise.prototype._settlePromises@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:2771:13
[1]</Async.prototype._drainQueue@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:163:13
[1]</Async.prototype._drainQueues@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:173:5
Async/this.drainQueues@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:47:9

End Inner Error Stack
------------------------------------------------

    AggregateError@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:15462:13
    invoke@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12645:15
    get@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12096:27
    get@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:12582:14
    ensureViewModel/<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:24085:58
From previous event:
    ensureViewModel@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:24078:16
    createController@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:24054:14
    _createControllerAndSwap@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:24033:14
    compose@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:24113:16
    compose@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:24381:14
    setRoot@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:13352:14
    configure/<@https://rem-dev.petabencana.id/scripts/app-bundle.js:425:14
From previous event:
    configure@https://rem-dev.petabencana.id/scripts/app-bundle.js:424:5
    config/<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11927:9
From previous event:
    config@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11922:14
    handleApp@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11913:12
    run/</</<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11946:13
From previous event:
    run/</<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11944:16
From previous event:
    run/<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11943:14
From previous event:
    run@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11939:12
    @https://rem-dev.petabencana.id/scripts/vendor-bundle.js:11966:3
    newContext/context.execCb@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:5891:24
    newContext/Module.prototype.check@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:5079:43
    newContext/Module.prototype.enable@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:5371:17
    newContext/context.enable@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:5752:21
    newContext/Module.prototype.enable/<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:5356:25
    bind/<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:4332:20
    each@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:4257:31
    newContext/Module.prototype.enable@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:5308:17
    newContext/Module.prototype.init@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:4984:21
    localRequire/<@https://rem-dev.petabencana.id/scripts/vendor-bundle.js:5655:25  vendor-bundle.js:1395:13```

        

Hi. Just noting there's a bug in dev in which after you login (now using universal auth0 thanks to @mehrdadgit's work) it still has the pre-login menu (with option to login "Masuk", rather than options for map "Peta" and logout "Keluar"). Neither of us know our way around aurelia routing well enough (yet) in order to fix it, but in light of other discussions around a rewrite of REM (and using Cognito) it doesn't seem worth fixing this bug. Also just flagging that dev now should not be merged into master as we've gone with two different auth0 ways of doing the login and merging dev -> master would break prod without some corresponding config changes.

during the training we receive a complain about our basemap (when reporting) which currently shows less updated info from the original OSM/mapbox web

perhaps as we limited our PB map scale to be zoomed in max in 100 m while OSM web up to 20 m?

• currently selected flood report (i.e. report modal is open) should be highlighted on the map

• Aurelia table to move highlighted row to top

Details in urbanriskmap/riskmap#220

Looks like:
Should look like

vendor-bundle.js:38880 GET https://rem-dev.petabencana.id/images/layers-2x.png 403 ()

Client UI: "Unexpected error updating flood state"
Web response:

{
  "status":401,
  "message":"invalid signature",
  "code":"invalid_token",
  "name":"UnauthorizedError"
}

According to https://auth0.com/docs/errors/libraries/auth0-js/invalid-token requesting responseType parameter to token id_token should fix it.

To recreate, occurs when:

• 'x' area is selected in 'a' district (using map or clicking on table row)
• select any area in 'b' district (map / table)
• on returning to 'a' district (using table), 'x' area row is not cleared / remains selected
• or using map, if 'y' area is clicked on in 'a' district, both 'x' and 'y' rows will be selected (however flood state update option is enabled only for 'y')

Options:

• seems like something to do with filtering areas based on district
• manually setting $isSelected property value of au-table row to false breaks browser - endlessly triggers clicks on layer (not sure why! - perhaps it is continuously polled by aurelia using a getter)

Leaflet has internal factory functions that return an instance. This is the leaflet design pattern, and so we should refactor to avoid use of new.

i.e.
var map = L.map();
not,
var map = new L.Map();

Trying to edit flood state returns an authentication error (403?)

• this only happens when first logging in on a new browser.

expected behavior:

• clicking check box items in legend changes their visibility on the map

current behavior:

• no change on map