Giter Club home page Giter Club logo

Comments (9)

jarekwg avatar jarekwg commented on August 27, 2024

Good spot!
Would you like to add it?

pymyob/myob/endpoints.py

Lines 31 to 36 in c6d7799

'Sale/CustomerPayment/': {
'name': 'customer_payments',
'methods': [
(ALL, '', 'sale customer payment type')
]
},

According to the docs
https://developer.myob.com/api/accountright/v2/sale/customerpayment/
we should also support:

(GET, '', 'sale customer payment'),
(POST, '', 'sale customer payment'),
(DELETE, '', 'sale customer payment'),

Bit of a non-standard endpoint, this one.

Also, should update the existing ALL one to not say type at the end, just 'sale customer payment'.

Cheers,

from pymyob.

HHry0918 avatar HHry0918 commented on August 27, 2024

I actually add CRUD on my computer for a quick fix for demonstration purpose so I'll push the correct version later

from pymyob.

jarekwg avatar jarekwg commented on August 27, 2024

Can leave the issue open until it's addressed.

from pymyob.

HHry0918 avatar HHry0918 commented on August 27, 2024

I have pushed the new code

from pymyob.

jarekwg avatar jarekwg commented on August 27, 2024

Where?

from pymyob.

HHry0918 avatar HHry0918 commented on August 27, 2024

Oh, I must not have pushed to this repo. Sorry about that, this is the 1st time I contributed to an open-source repo

from pymyob.

HHry0918 avatar HHry0918 commented on August 27, 2024

I accidentally fork this repo into my own repo and the pushed wasn't directing to this repo. Silly me

from pymyob.

jarekwg avatar jarekwg commented on August 27, 2024

That's the right way to do it -- you fork the repo, push your changes, then open a PR here, where you propose for the changes in your fork to be merged here.

from pymyob.

jarekwg avatar jarekwg commented on August 27, 2024

Resolved in #64

from pymyob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.