Comments (4)
Hi @paladin0,
Interesting. I've just had a quick read of the plan for essentials API. Looks like it's very compatible.
I believe all we'd need is a product
flag to pass into the Myob
constructor. For backwards compatibility, can default to accountright
, but can be set to essentials
. This will then dictate what base url is used.
The endpoints really do appear identical, which is pretty cool:
https://developer.myob.com/api/accountright/v2/contact/
https://developer.myob.com/api/accountright/essentials-new-v2/contact/
So I think we wouldn't need to bother with a separate endpoints file. Wherever there's missing feature parity, we'd leave it to MYOB's api to let the user know the endpoint is unavailable. If this turns out to be a bad idea, can always split them off in future.
So to answer your question, I think support for the new essentials can definitely be added to this package. Would you be interested in offering a PR to get us started?
Cheers,
from pymyob.
I think keeping them as the same is fine
however is this package already V2 compatible? as they have changed a few things
https://developer.myob.com/api/accountright/api-overview/v2-changes/
as i think there are more changes needed
from pymyob.
Yep, this package only supports AccountRight Live API v2.
Line 138 in 03fedac
from pymyob.
It appears the two have been merged entirely now. https://developer.myob.com/api/accountright/v2/
Probs safe to close this off.
from pymyob.
Related Issues (20)
- Update flow to not require companyfile credentials passed. HOT 2
- Unable to setup with the package HOT 6
- Company list returns blank HOT 3
- KeyError: 'There are no stored username-password credentials for this company id.' HOT 4
- Modernise pipeline HOT 1
- Support for Report api endpoints HOT 2
- Using 'ge' (greater than) and 'le' (less than) in GET filter HOT 2
- Invalid client_id HOT 6
- Unable to install master HOT 5
- Empty string returned from API causes JSON error HOT 6
- customer_payments doesn't have POST method HOT 9
- Code does not catch error from simplejson HOT 4
- Accessing Nested Resources HOT 2
- x-myobapi-cftoken header not needed sometimes HOT 2
- Using this library with an access_token rather than creds HOT 3
- How does one use $top, $filter, etc. ? HOT 4
- Add endpoint ALL accountregister
- Swap to Poetry
- Add Black CI check
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymyob.