Giter Club home page Giter Club logo

Comments (4)

jarekwg avatar jarekwg commented on August 27, 2024

Hi @paladin0,

Interesting. I've just had a quick read of the plan for essentials API. Looks like it's very compatible.

I believe all we'd need is a product flag to pass into the Myob constructor. For backwards compatibility, can default to accountright, but can be set to essentials. This will then dictate what base url is used.
The endpoints really do appear identical, which is pretty cool:
https://developer.myob.com/api/accountright/v2/contact/
https://developer.myob.com/api/accountright/essentials-new-v2/contact/
So I think we wouldn't need to bother with a separate endpoints file. Wherever there's missing feature parity, we'd leave it to MYOB's api to let the user know the endpoint is unavailable. If this turns out to be a bad idea, can always split them off in future.

So to answer your question, I think support for the new essentials can definitely be added to this package. Would you be interested in offering a PR to get us started?

Cheers,

from pymyob.

paladin0 avatar paladin0 commented on August 27, 2024

I think keeping them as the same is fine

however is this package already V2 compatible? as they have changed a few things
https://developer.myob.com/api/accountright/api-overview/v2-changes/

as i think there are more changes needed

from pymyob.

jarekwg avatar jarekwg commented on August 27, 2024

Yep, this package only supports AccountRight Live API v2.

'x-myobapi-version': 'v2',

from pymyob.

jarekwg avatar jarekwg commented on August 27, 2024

It appears the two have been merged entirely now. https://developer.myob.com/api/accountright/v2/
Probs safe to close this off.

from pymyob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.