upnext / beaconcontrol_android_sample_app Goto Github PK

It is possible to enter a sample beacon on the web admin interface with illegal values (i.e. major/minor > 65.535). This makes the app crash on the beacons tab when it tries to add a new region in the SDK (ClientsManager.addNewRegion)

See the method's code below:

private void addNewRegion(BeaconModel bm) {
        Region region = new Region(bm.getUniqueId(), Identifier.parse(bm.getProximityUUID()), Identifier.parse(bm.getProximityMajor().toString()), Identifier.parse(bm.getProximityMinor().toString()));
       ...
}

In my example, neither the ProximityUUID nor the major/minor could not be parsed. Maybe more checks and a message to the user should be added? However, I was able to fix to ProximityUUID by using Identifier.fromUuid(UUID.fromString(bm.getProximityUUID())). Maybe the web interface should also not accept illegal values for major/minor.

Hi,

I have installed the beacon control sample app and tried to trigger the url actions via application page by assigning a zone with beacon devices, when i open the beacon control app it crashes and shows error as unfortunately app has been stopped.

Kindly suggest me a solution for this.

My Log shows as

06-12 04:42:43.901 19445-19445/io.upnext.beaconcontrol.app E/AndroidRuntime: FATAL EXCEPTION: main Process: io.upnext.beaconcontrol.app, PID: 19445 java.lang.NullPointerException: Attempt to invoke interface method 'boolean java.util.List.removeAll(java.util.Collection)' on a null object reference at io.upnext.beaconcontrol.sdk.backend.service.BeaconServiceHelper.removeUnsupportedRangesFromTriggers(BeaconServiceHelper.java:116) at io.upnext.beaconcontrol.sdk.backend.service.BeaconServiceHelper.handleUnsupportedProtocols(BeaconServiceHelper.java:91) at io.upnext.beaconcontrol.sdk.backend.service.BeaconServiceHelper.access$000(BeaconServiceHelper.java:30) at io.upnext.beaconcontrol.sdk.backend.service.BeaconServiceHelper$1.onSuccess(BeaconServiceHelper.java:65) at io.upnext.beaconcontrol.sdk.backend.service.BeaconServiceHelper$1.onSuccess(BeaconServiceHelper.java:62) at io.upnext.beaconcontrol.sdk.backend.mediator.HttpCallMediator.notifyOnSuccess(HttpCallMediator.java:62) at io.upnext.beaconcontrol.sdk.backend.mediator.HttpCallMediator.access$100(HttpCallMediator.java:23) at io.upnext.beaconcontrol.sdk.backend.mediator.HttpCallMediator$1.onSuccess(HttpCallMediator.java:97) at io.upnext.beaconcontrol.sdk.backend.BeaconControlCallback.onResponse(BeaconControlCallback.java:20) at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:68) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:148) at android.app.ActivityThread.main(ActivityThread.java:7303) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)