The sharpdups's discuss from unruledboy

sharpdups's Issues

Crash on System.UnauthorizedAccessException

If a folder is not accessible because of missing access rights the application crashes.

Missing try / catch (Directory.GetFiles(folder, ".", SearchOption.AllDirectories)

var files = Directory.GetFiles(folder, ".", SearchOption.AllDirectories);
in private static void Run(IDupDetector dupDetector, int workers, string folder)
throws an System.UnauthorizedAccessException:
{"Der Zugriff auf den Pfad "d:\$RECYCLE.BIN\S-1-5-18" wurde verweigert."}

This kind of exception is quit normal and must be catched.

Just for info.

I wrote for this problem a small class

public class DirEx {

    static public event EventHandler<string> OnError = (s, a) => { };


    static public void ForEveryFile(string path, Action<string> worker) {
        if (worker == null)
            throw new Exception("worker must have a value");
        try {
            try {
                foreach (string f in Directory.GetFiles(path)) {
                    worker.Invoke(f);
                }
            }
            catch (UnauthorizedAccessException) { }
            catch (Exception ex) {
                string errormsg = $"{path} -> {ex.Message}";
                OnError.Invoke(null, errormsg);
                Trace.WriteLine(errormsg);
            }

            foreach (string d in Directory.GetDirectories(path)) {
                ForEveryFile(d, worker);
            }
        }
        catch (Exception ex) {
            string errormsg = $"{path} -> {ex.Message}";
            OnError.Invoke(null, errormsg);
            Trace.WriteLine(errormsg);
        }
    }
}

Recommend Projects