Comments (4)
ivarconr
commented on May 27, 2024
Thanks for reporting. I will look in to it.
This surprises me a bit sense the unleash SDK tries to only use a single dedicated thread for metrics handling.
How many instances of the unleash client do you instantiate in your application?
from unleash-client-java.
aleksabl
commented on May 27, 2024
We only have a single instance. If you look at the stack trace you'll see pretty clearly that DefaultUnleash.isEnabled calls count (which ends up in MetricsBucket.registerCount in the same thread). I haven't looked much at the code, but maybe count should have been done through the event dispatcher (at ToggleEvaluated)?
from unleash-client-java.
ivarconr
commented on May 27, 2024
Thanks, you are absolutely right, ConcurrentHashMap is the correct solution in this scenario.
Multiple threads knocking on MetricsBucket.registerCount() could from time to time trigger concurrency issues (even though I cant find any traces of this happening across our java apps, but I am able to reproduce in controlled experiment)
released a fix as 3.2.4.
from unleash-client-java.
aleksabl
commented on May 27, 2024
Hi, thanks for looking into it. I had a look at the code and I still found several issues regarding thread safety.
I'll try to fix the issues I found and send a pull request today.
from unleash-client-java.
Related Issues (20)
- Refactor DefaultUnleash to make it customizable with different implementation of IFeatureRepository HOT 1
- Sanitize appName for backupFile HOT 5
- Why use a `BiFunction` when the desired interface was a `BiPredicate`? HOT 1
- Unleash Codegen Gradle Plugin HOT 8
- DefaultUnleash.isEnabled(toggleName, context) silently dropping context HOT 4
- FakeUnleash enable all except certain features HOT 6
- Make Backuphandler extensible HOT 1
- Impression data flag as part of getFeatureToggleDefinition HOT 1
- Client specification header makes server send stale information HOT 12
- SDK exposes Api key in logs
- Missing 8.3.0 release artifact in maven HOT 3
- Strategy check return only the first enabled HOT 3
- Compatability Matrix HOT 2
- Update from 8.3.1 to 9.1.0 changes variant on existing features flags HOT 7
- Remove (again) our deprecated hashing methods
- Filter for tags HOT 2
- Add featureEnabled to variant response HOT 1
- Proxy authentication not working HOT 1
- String operator STR_STARTS_WITH is not evaluated correctly when case-sensative is disabled HOT 6
- FakeUnleash doesn't take into account global activation/deactivation for certain isEnabled method HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unleash-client-java.