Comments (5)
Hey @ajdergute, I believe this is actually a bug on the Gitlab side. We by design don't allow slashes in environment names, so you'd need to sanitise those before creating the environments. Would you be able to raise this with the Gitlab team instead?
from unleash-client-java.
GitLab by design allows slashes (beside other characters) for it's environment names.
Refer to: https://docs.gitlab.com/ee/ci/environments/index.html#create-a-dynamic-environment
And: https://docs.gitlab.com/ee/ci/yaml/index.html#environmentname
Please mind, that the "gitlab environment" is mapped to "unleash appName". I'm not aware if this is a good idea.
Anyway, I'm not able to get some restrictions out of unleash documentation. The only information I found is:
https://docs.getunleash.io/reference/api/unleash/register-client-application
As per this documentation any string is allowed as appName. If it's on GitLab side it would be very helpful if I could point to some documentation. I'm able to raise this at GitLab, but I'm not convinced that it's really an issue with GitLab.
from unleash-client-java.
Ah right, fair enough, I think I've misunderstood your original question, apologies for that! Environment names wouldn't get mapped to app names in Unleash, so it's not practically a problem outside of Gitlab. That aside I can see how it'd be a pain to deal with. The config in this SDK should allow you to set your own backup file path, which is probably what I would suggest. Otherwise, it's open source so if you'd be open to submitting a PR, we'd be open to looking.
from unleash-client-java.
Hey, @ajdergute ππΌ We haven't heard from you in a bit now and I see @sighphyre suggested a potential workaround for the backup file path. Did that work out for you?
As @sighphyre also said, this seems to be an issue with how GitLab uses Unleash and not with this SDK itself, so I'm going to go ahead and close this issue for now. Feel free to re-open it if you think it's warranted, though.
from unleash-client-java.
Sorry for my late reply. The workaround from @sighphyre doesn't work for me. I created an PR and open for any discussion.
If desired, I'm able to change this PR to make the backupFilePath configurable.
from unleash-client-java.
Related Issues (20)
- Why use a `BiFunction` when the desired interface was a `BiPredicate`? HOT 1
- Unleash Codegen Gradle Plugin HOT 8
- DefaultUnleash.isEnabled(toggleName, context) silently dropping context HOT 4
- FakeUnleash enable all except certain features HOT 6
- Make Backuphandler extensible HOT 1
- Impression data flag as part of getFeatureToggleDefinition HOT 1
- Client specification header makes server send stale information HOT 12
- SDK exposes Api key in logs
- Missing 8.3.0 release artifact in maven HOT 3
- Strategy check return only the first enabled HOT 3
- Compatability Matrix HOT 2
- Update from 8.3.1 to 9.1.0 changes variant on existing features flags HOT 7
- Remove (again) our deprecated hashing methods
- Filter for tags HOT 2
- Add featureEnabled to variant response HOT 1
- Proxy authentication not working HOT 1
- String operator STR_STARTS_WITH is not evaluated correctly when case-sensative is disabled HOT 6
- FakeUnleash doesn't take into account global activation/deactivation for certain isEnabled method HOT 2
- Wrong toggle evaluation with dependencies HOT 5
- CHANGELOG.md file is severely outdated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unleash-client-java.