Extend the unleash interface with context-data about unleash-client-java HOT 6 CLOSED

(from Unleash/unleash#99)

from unleash-client-java.

After years of usage i finn we see that a UnleashContext with the following properties would make it simple to standardize a lot of strategies (all fields are of course optional):

UnleashContext::
 userId: String,
 sessionId: String,
 remoteAddress: String,
 properties: Map<String, String>

It should be possible to provide the context via a request-bound provider (e.g. in a request scoped spring bean, or similar).

It should also be possible to send in the UnleashContext as part of the "isEnabled" call (just in time). This is very convenient in non-thread based environment where the user/request details is available just in place.

from unleash-client-java.

Suggestion:

should we change the properties field to be a just a list of flags instead? The only use case we have for it at the moment us to flag a user as a beta-user. This feels a bit cumbersome in a key,value structure.

Aka:

 userId: String,
 sessionId: String,
 remoteAddress: String,
 flags: Array<String>

What do you think @sveisvei and @vsandvold ?

from unleash-client-java.

Key value feels a bit awkward, but is more flexible of course. For the abtest strategy I thought about providing context for device, referrer and other useful properties for segmentation. Currently it's only the USERID cookie value that is provided.

Another thing... Could it be useful to have multiple context providers, like BetaUserContextProvider and ABTestContextProvider?

from unleash-client-java.

Currently it's only the USERID cookie value that is provided

yes, then key/value is required i suppose, better keep the properties then.

Could it be useful to have multiple context providers, like BetaUserContextProvider and ABTestContextProvider?

No, the whole purpose is to provide one context and one entry point for it! It's better to make it flexible enough to add what we need, IMHO.

from unleash-client-java.

solved in #33

from unleash-client-java.