Change strategy interface about unleash-client-java HOT 4 CLOSED

Do they want to use the toggleName as part of the hash input? Would this solve it, and some javadoc added to the Strategy interface with "The client always add "toggleName" to the parameters map"?

    ToggleCollection(final Collection<FeatureToggle> features) {
        this.features = features;
        cache = new HashMap<>();
        for(FeatureToggle featureToggle : features) {
            String featureToggleName = featureToggle.getName();
            featureToggle.getParameters().put("toggleName",featureToggleName);
            cache.put(featureToggleName, featureToggle);
        }
    }

from unleash-client-java.

Isn't this exactly why we have parameters? I think adding the toggleName argument (or inject it into the parameters by default) suggests that it's OK to couple strategy implementations tightly to the various toggles that may be using it, which is not what we want.

And although the use case is compelling, I'm not sure that the toggle name will always be the best key to use for consistent grouping/hashing. What if someone wants to share the "user groups" across several toggles? Then it would make a lot more sense to have it as a parameter.

So my vote is 👎 for make the strategy aware of toggle names, and 👍 for using a parameter for this.

from unleash-client-java.

I disagree with your suggestion @sveinelo , we should NOT manipulate the config params.

@jarib has a valid point and I withdraw my suggestion on changing the API.

from unleash-client-java.

👍 for using parameters for this

from unleash-client-java.